Issue 2869333003: Add more arguments to JS pseudo-function - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(100)

My Issues | Starred Open | Closed | All

Issue 2869333003: Add more arguments to JS pseudo-function (Closed)

Created:
3 years, 7 months ago by sra1

Modified:
3 years, 7 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add more arguments to JS pseudo-function TBR=sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/d9e094b906fe547b98445fd3d996c626a47779c6

Patch Set 1 #

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -1 line)			Patch
	M	sdk/lib/_internal/js_runtime/lib/foreign_helper.dart	View		1 chunk	+20 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sra1

Committed patchset #1 (id:1) manually as d9e094b906fe547b98445fd3d996c626a47779c6 (presubmit successful).

3 years, 7 months ago (2017-05-10 21:03:59 UTC) #2

Message was sent while issue was closed.

lgtm, of course

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Powered by Google App Engine

This is Rietveld 408576698