Introduce the MaskedViewTargeter class

Introduce the MaskedViewTargeter class

Introduce MaskedViewTargeter, a derived class of ViewTargeter.
Classes deriving from MaskedViewTargeter will be used to define a
custom-shaped hit test mask on a view to be considered in
event targeting.

BUG=375826
TEST=ViewTargeterTest.MaskedViewTargeter

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273023

[tdanderson, 2014-05-21 18:12:18]

Sadrul, PTAL.

[tdanderson, 2014-05-21 20:56:06]

On 2014/05/21 18:12:18, tdanderson wrote:
> Sadrul, PTAL.

Sadrul, I am getting the following error from linux_chromium_clang_dbg but
cannot reproduce it locally. Can you provide any guidance as to why this is?

../../ui/views/view_targeter_unittest.cc:20: error: undefined reference to
'views::MaskedViewTargeter::MaskedViewTargeter(views::View*)'
../../ui/views/view_targeter_unittest.cc:22: error: undefined reference to
'views::MaskedViewTargeter::~MaskedViewTargeter()'
obj/ui/views/views_unittests.view_targeter_unittest.o:../../ui/views/view_targeter_unittest.cc:vtable
for views::TestMaskedViewTargeter: error: undefined reference to
'views::MaskedViewTargeter::EventLocationInsideBounds(ui::EventTarget*,
ui::LocatedEvent const&) const'

[sadrul, 2014-05-21 21:10:39]

On 2014/05/21 20:56:06, tdanderson wrote:
> On 2014/05/21 18:12:18, tdanderson wrote:
> > Sadrul, PTAL.
> 
> Sadrul, I am getting the following error from linux_chromium_clang_dbg but
> cannot reproduce it locally. Can you provide any guidance as to why this is?
> 
> ../../ui/views/view_targeter_unittest.cc:20: error: undefined reference to
> 'views::MaskedViewTargeter::MaskedViewTargeter(views::View*)'
> ../../ui/views/view_targeter_unittest.cc:22: error: undefined reference to
> 'views::MaskedViewTargeter::~MaskedViewTargeter()'
>
obj/ui/views/views_unittests.view_targeter_unittest.o:../../ui/views/view_targeter_unittest.cc:vtable
> for views::TestMaskedViewTargeter: error: undefined reference to
> 'views::MaskedViewTargeter::EventLocationInsideBounds(ui::EventTarget*,
> ui::LocatedEvent const&) const'

VIEWS_EXPORT the MaskedViewTargeter?

[tdanderson, 2014-05-21 21:24:17]

On 2014/05/21 21:10:39, sadrul wrote:
> On 2014/05/21 20:56:06, tdanderson wrote:
> > On 2014/05/21 18:12:18, tdanderson wrote:
> > > Sadrul, PTAL.
> > 
> > Sadrul, I am getting the following error from linux_chromium_clang_dbg but
> > cannot reproduce it locally. Can you provide any guidance as to why this is?
> > 
> > ../../ui/views/view_targeter_unittest.cc:20: error: undefined reference to
> > 'views::MaskedViewTargeter::MaskedViewTargeter(views::View*)'
> > ../../ui/views/view_targeter_unittest.cc:22: error: undefined reference to
> > 'views::MaskedViewTargeter::~MaskedViewTargeter()'
> >
>
obj/ui/views/views_unittests.view_targeter_unittest.o:../../ui/views/view_targeter_unittest.cc:vtable
> > for views::TestMaskedViewTargeter: error: undefined reference to
> > 'views::MaskedViewTargeter::EventLocationInsideBounds(ui::EventTarget*,
> > ui::LocatedEvent const&) const'
> 
> VIEWS_EXPORT the MaskedViewTargeter?

Thanks, I have done this in PS2.

[tfarina, 2014-05-21 21:33:36]

On 2014/05/21 21:24:17, tdanderson wrote:
> On 2014/05/21 21:10:39, sadrul wrote:
> > On 2014/05/21 20:56:06, tdanderson wrote:
> > > On 2014/05/21 18:12:18, tdanderson wrote:
> > > > Sadrul, PTAL.
> > > 
> > > Sadrul, I am getting the following error from linux_chromium_clang_dbg but
> > > cannot reproduce it locally. Can you provide any guidance as to why this
is?
> > > 
> > > ../../ui/views/view_targeter_unittest.cc:20: error: undefined reference to
> > > 'views::MaskedViewTargeter::MaskedViewTargeter(views::View*)'
> > > ../../ui/views/view_targeter_unittest.cc:22: error: undefined reference to
> > > 'views::MaskedViewTargeter::~MaskedViewTargeter()'
> > >
> >
>
obj/ui/views/views_unittests.view_targeter_unittest.o:../../ui/views/view_targeter_unittest.cc:vtable
> > > for views::TestMaskedViewTargeter: error: undefined reference to
> > > 'views::MaskedViewTargeter::EventLocationInsideBounds(ui::EventTarget*,
> > > ui::LocatedEvent const&) const'
> > 
> > VIEWS_EXPORT the MaskedViewTargeter?
> 
> Thanks, I have done this in PS2.

You are probably doing a static build while the bot is doing a shared one.

[sadrul, 2014-05-27 16:03:32]

lgtm

https://codereview.chromium.org/286933014/diff/40001/ui/views/view_targeter.cc
File ui/views/view_targeter.cc (right):

https://codereview.chromium.org/286933014/diff/40001/ui/views/view_targeter.c...
ui/views/view_targeter.cc:20: event);
The formatting here seems a bit weird. What would 'git cl format' do?

https://codereview.chromium.org/286933014/diff/40001/ui/views/view_targeter.c...
ui/views/view_targeter.cc:21: event_bounds = gesture.details().bounding_box();
Can you return a RectF instead (and get bounding_box_f())?

[tdanderson, 2014-05-27 16:24:06]

The CQ bit was checked by tdanderson@chromium.org

[tdanderson, 2014-05-27 16:24:46]

https://codereview.chromium.org/286933014/diff/40001/ui/views/view_targeter.cc
File ui/views/view_targeter.cc (right):

https://codereview.chromium.org/286933014/diff/40001/ui/views/view_targeter.c...
ui/views/view_targeter.cc:20: event);
On 2014/05/27 16:03:32, sadrul wrote:
> The formatting here seems a bit weird. What would 'git cl format' do?

Done.

https://codereview.chromium.org/286933014/diff/40001/ui/views/view_targeter.c...
ui/views/view_targeter.cc:21: event_bounds = gesture.details().bounding_box();
On 2014/05/27 16:03:32, sadrul wrote:
> Can you return a RectF instead (and get bounding_box_f())?

Done.

[commit-bot: I haz the power, 2014-05-27 16:24:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tdanderson@chromium.org/286933014/50001

[sadrul, 2014-05-27 16:26:17]

https://codereview.chromium.org/286933014/diff/50001/ui/views/view_targeter.cc
File ui/views/view_targeter.cc (right):

https://codereview.chromium.org/286933014/diff/50001/ui/views/view_targeter.c...
ui/views/view_targeter.cc:17: gfx::RectF event_bounds(event.location(),
gfx::Size(1, 1));
Another quick nit: event.location_f() and gfx::SizeF(1, 1)?

[tdanderson, 2014-05-27 16:27:20]

The CQ bit was unchecked by tdanderson@chromium.org

[tdanderson, 2014-05-27 16:30:07]

https://codereview.chromium.org/286933014/diff/50001/ui/views/view_targeter.cc
File ui/views/view_targeter.cc (right):

https://codereview.chromium.org/286933014/diff/50001/ui/views/view_targeter.c...
ui/views/view_targeter.cc:17: gfx::RectF event_bounds(event.location(),
gfx::Size(1, 1));
On 2014/05/27 16:26:18, sadrul wrote:
> Another quick nit: event.location_f() and gfx::SizeF(1, 1)?

Oops, sorry, forgot to change accordingly. Done.

[tdanderson, 2014-05-27 16:30:12]

The CQ bit was checked by tdanderson@chromium.org

[commit-bot: I haz the power, 2014-05-27 16:31:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tdanderson@chromium.org/286933014/70001

[commit-bot: I haz the power, 2014-05-27 19:37:29]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-27 19:39:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-27 19:39:09]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)

[tdanderson, 2014-05-27 19:39:39]

The CQ bit was checked by tdanderson@chromium.org

[commit-bot: I haz the power, 2014-05-27 19:40:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tdanderson@chromium.org/286933014/70001

[commit-bot: I haz the power, 2014-05-27 20:55:58]

Change committed as 273023