Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 286933012: Remove unneeded functions in web_app.cc. (Closed)

Created:
6 years, 7 months ago by jackhou1
Modified:
6 years, 7 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Remove unneeded functions in web_app.cc. The main change here is that web_app::GetWebAppDataDirectory is now being called on the UI thread. BUG=356889 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272422

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -45 lines) Patch
M chrome/browser/web_applications/web_app.cc View 6 chunks +18 lines, -45 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jackhou1
6 years, 7 months ago (2014-05-21 07:13:26 UTC) #1
calamity
lgtm.
6 years, 7 months ago (2014-05-21 08:49:40 UTC) #2
jackhou1
The CQ bit was checked by jackhou@chromium.org
6 years, 7 months ago (2014-05-22 01:50:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/286933012/1
6 years, 7 months ago (2014-05-22 01:53:43 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 11:52:18 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 11:54:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9742)
6 years, 7 months ago (2014-05-22 11:54:36 UTC) #7
jackhou1
The CQ bit was checked by jackhou@chromium.org
6 years, 7 months ago (2014-05-23 03:17:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/286933012/1
6 years, 7 months ago (2014-05-23 03:19:49 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 07:07:22 UTC) #10
Message was sent while issue was closed.
Change committed as 272422

Powered by Google App Engine
This is Rietveld 408576698