Remove most references to VarPrivate/InstancePrivate from OOP PDF

Remove most references to VarPrivate/InstancePrivate from OOP PDF

This removes most references to VarPrivate and InstancePrivate from
OOP PDF. These APIs are deprecated and we'd like to remove them.
In most cases where they are currently used, we can simply switch
to using a PostMessage to communicate with the extension. In the
case of modal dialogs, these need to run synchronously from the
perspective of the PDF engine and so PostMessage isn't sufficient.
Right now these calls still use InstancePrivate but we should switch
to using a specific private API eventually.

BUG=303491
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271998

[Lei Zhang, 2014-05-21 01:28:55]

lgtm

https://codereview.chromium.org/286933011/diff/40001/pdf/out_of_process_insta...
File pdf/out_of_process_instance.cc (right):

https://codereview.chromium.org/286933011/diff/40001/pdf/out_of_process_insta...
pdf/out_of_process_instance.cc:213: const PPB_Instance_Private* interface =
Is it possible to sanely handle the case where the returned ptr is NULL?

[raymes, 2014-05-21 01:44:22]

On 2014/05/21 01:28:55, Lei Zhang wrote:
> lgtm
> 
>
https://codereview.chromium.org/286933011/diff/40001/pdf/out_of_process_insta...
> File pdf/out_of_process_instance.cc (right):
> 
>
https://codereview.chromium.org/286933011/diff/40001/pdf/out_of_process_insta...
> pdf/out_of_process_instance.cc:213: const PPB_Instance_Private* interface =
> Is it possible to sanely handle the case where the returned ptr is NULL?

Since PDF is bundled with Chrome this should never be null so crashing is
reasonable here.

[raymes, 2014-05-21 01:44:27]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2014-05-21 01:46:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/raymes@chromium.org/286933011/40001

[commit-bot: I haz the power, 2014-05-21 07:49:58]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-21 22:49:59]

Change committed as 271998