Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1705)

Unified Diff: components/safe_browsing/password_protection/password_protection_service.cc

Issue 2869253002: Add UMA metrics to phishguard pings (Closed)
Patch Set: fix unittest Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing/password_protection/password_protection_service.cc
diff --git a/components/safe_browsing/password_protection/password_protection_service.cc b/components/safe_browsing/password_protection/password_protection_service.cc
index ee3af7cda3a1918f2f4612517faa78cbaa57bd5f..8d560cbbc04bb6465320a0cbdfcfafc35974d680 100644
--- a/components/safe_browsing/password_protection/password_protection_service.cc
+++ b/components/safe_browsing/password_protection/password_protection_service.cc
@@ -70,6 +70,11 @@ const base::Feature kPasswordFieldOnFocusPinging{
const base::Feature kProtectedPasswordEntryPinging{
"ProtectedPasswordEntryPinging", base::FEATURE_DISABLED_BY_DEFAULT};
+const char kPasswordOnFocusRequestOutcomeHistogramName[] =
+ "PasswordProtection.RequestOutcome.PasswordFieldOnFocus";
+const char kPasswordEntryRequestOutcomeHistogramName[] =
+ "PasswordProtection.RequestOutcome.ProtectedPasswordEntry";
+
PasswordProtectionService::PasswordProtectionService(
const scoped_refptr<SafeBrowsingDatabaseManager>& database_manager,
scoped_refptr<net::URLRequestContextGetter> request_context_getter,
@@ -216,7 +221,7 @@ void PasswordProtectionService::StartRequest(
requests_.insert(std::move(request));
}
-void PasswordProtectionService::MaybeStartLowReputationRequest(
+void PasswordProtectionService::MaybeStartPasswordFieldOnFocusRequest(
const GURL& main_frame_url,
const GURL& password_form_action,
const GURL& password_form_frame_url) {

Powered by Google App Engine
This is Rietveld 408576698