Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2869253002: Add UMA metrics to phishguard pings (Closed)
Patch Set: resolve comments on histograms.xml Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « tools/metrics/histograms/enums.xml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 68206764ad76095705618b2d6a55f02b4f3164a1..b805eb69ee71c9b9717a6995a4140205e23e0706 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -49926,6 +49926,10 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="PasswordProtection.PasswordReuseEventVerdict"
enum="PasswordProtectionVerdict">
+ <obsolete>
+ Deprecated since May 12 2017. Replaced by
+ PasswordProtection.Verdict.ProtectedPasswordEntry.
+ </obsolete>
<owner>jialiul@chromium.org</owner>
<owner>nparker@chromium.org</owner>
<summary>
@@ -49942,7 +49946,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
-<histogram name="PasswordProtection.RequestOutcome"
+<histogram base="true" name="PasswordProtection.RequestOutcome"
enum="PasswordProtectionRequestOutcome">
<owner>jialiul@chromium.org</owner>
<owner>nparker@chromium.org</owner>
@@ -49955,6 +49959,10 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="PasswordProtection.UnfamiliarLoginPageVerdict"
enum="PasswordProtectionVerdict">
+ <obsolete>
+ Deprecated since May 12 2017. Replaced by
+ PasswordProtection.Verdict.PasswordFieldOnFocus.
+ </obsolete>
<owner>jialiul@chromium.org</owner>
<owner>nparker@chromium.org</owner>
<summary>
@@ -49962,6 +49970,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="PasswordProtection.Verdict" enum="PasswordProtectionVerdict">
+ <owner>jialiul@chromium.org</owner>
+ <owner>nparker@chromium.org</owner>
+ <summary>
+ Verdict types returned by Safe Browsing server for a password protection
+ request. Request can be triggered when user focuses on a password field or
+ enters a protected password.
+ </summary>
+</histogram>
+
<histogram
name="PaymentRequest.CanMakePayment.NotUsed.WithShowEffectOnCompletion"
enum="PaymentRequestFlowCompletionStatus">
@@ -89834,6 +89852,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<affected-histogram name="PasswordManager.SavePasswordPromptResponse"/>
</histogram_suffixes>
+<histogram_suffixes name="PasswordProtectionTrigger">
+ <suffix name="PasswordFieldOnFocus"
+ label="Password protection triggered by password field on focus event."/>
+ <suffix name="ProtectedPasswordEntry"
+ label="Password protection triggered by password reuse event."/>
+ <affected-histogram name="PasswordProtection.RequestOutcome"/>
+ <affected-histogram name="PasswordProtection.Verdict"/>
+</histogram_suffixes>
+
<histogram_suffixes name="PasswordReuseSourceRealm" separator=".">
<suffix name="FromHttpRealm"
label="The account in question was saved on an HTTP site."/>
« no previous file with comments | « tools/metrics/histograms/enums.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698