Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: components/safe_browsing/password_protection/password_protection_request.h

Issue 2869253002: Add UMA metrics to phishguard pings (Closed)
Patch Set: resolve comments on histograms.xml Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing/password_protection/password_protection_request.h
diff --git a/components/safe_browsing/password_protection/password_protection_request.h b/components/safe_browsing/password_protection/password_protection_request.h
index 80193e234320c5c7deba0c60cf0cdbe54c2ab5dd..321d95696047af262719daeaf6c0b8c4e9f03435 100644
--- a/components/safe_browsing/password_protection/password_protection_request.h
+++ b/components/safe_browsing/password_protection/password_protection_request.h
@@ -40,24 +40,6 @@ class PasswordProtectionRequest : public base::RefCountedThreadSafe<
content::BrowserThread::DeleteOnUIThread>,
public net::URLFetcherDelegate {
public:
- // The outcome of the request. These values are used for UMA.
- // DO NOT CHANGE THE ORDERING OF THESE VALUES.
- enum RequestOutcome {
- UNKNOWN = 0,
- SUCCEEDED = 1,
- CANCELED = 2,
- TIMEDOUT = 3,
- MATCHED_WHITELIST = 4,
- RESPONSE_ALREADY_CACHED = 5,
- DEPRECATED_NO_EXTENDED_REPORTING = 6,
- DEPRECATED_INCOGNITO = 7,
- REQUEST_MALFORMED = 8,
- FETCH_FAILED = 9,
- RESPONSE_MALFORMED = 10,
- SERVICE_DESTROYED = 11,
- MAX_OUTCOME
- };
-
PasswordProtectionRequest(const GURL& main_frame_url,
const GURL& password_form_action,
const GURL& password_form_frame_url,
@@ -115,7 +97,7 @@ class PasswordProtectionRequest : public base::RefCountedThreadSafe<
void StartTimeout();
// |this| will be destroyed after calling this function.
- void Finish(RequestOutcome outcome,
+ void Finish(PasswordProtectionService::RequestOutcome outcome,
std::unique_ptr<LoginReputationClientResponse> response);
// Main frame URL of the login form.

Powered by Google App Engine
This is Rietveld 408576698