Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 286923003: Observe ConnectionState changed events in TrayNetworkStateObserver (Closed)

Created:
6 years, 7 months ago by stevenjb
Modified:
6 years, 7 months ago
Reviewers:
jennyz, Ben Chan
CC:
chromium-reviews, sadrul, stevenjb+watch_chromium.org, ben+ash_chromium.org, oshima+watch_chromium.org, kalyank
Visibility:
Public.

Description

Observe ConnectionState changed events in TrayNetworkStateObserver BUG=374452 R=benchan@chromium.org, jennyz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271706

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M ash/system/chromeos/network/tray_network_state_observer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/system/chromeos/network/tray_network_state_observer.cc View 1 2 1 chunk +17 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
stevenjb
6 years, 7 months ago (2014-05-16 23:16:15 UTC) #1
Ben Chan
lgtm https://codereview.chromium.org/286923003/diff/20001/ash/system/chromeos/network/tray_network_state_observer.cc File ash/system/chromeos/network/tray_network_state_observer.cc (right): https://codereview.chromium.org/286923003/diff/20001/ash/system/chromeos/network/tray_network_state_observer.cc#newcode60 ash/system/chromeos/network/tray_network_state_observer.cc:60: // be called in addtion to NetworkConnectionStateChanged for ...
6 years, 7 months ago (2014-05-16 23:24:26 UTC) #2
stevenjb
https://codereview.chromium.org/286923003/diff/20001/ash/system/chromeos/network/tray_network_state_observer.cc File ash/system/chromeos/network/tray_network_state_observer.cc (right): https://codereview.chromium.org/286923003/diff/20001/ash/system/chromeos/network/tray_network_state_observer.cc#newcode60 ash/system/chromeos/network/tray_network_state_observer.cc:60: // be called in addtion to NetworkConnectionStateChanged for connection ...
6 years, 7 months ago (2014-05-16 23:29:29 UTC) #3
jennyz
lgtm
6 years, 7 months ago (2014-05-16 23:31:14 UTC) #4
stevenjb
The CQ bit was checked by stevenjb@chromium.org
6 years, 7 months ago (2014-05-19 16:21:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/286923003/40001
6 years, 7 months ago (2014-05-19 16:22:31 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-19 19:45:02 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-19 21:07:26 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/28527)
6 years, 7 months ago (2014-05-19 21:07:27 UTC) #9
stevenjb
6 years, 7 months ago (2014-05-20 18:00:44 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 manually as r271706 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698