Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Unified Diff: ios/chrome/browser/ui/sad_tab/sad_tab_view.mm

Issue 2869223002: Metrics logging for user engagement of the Reload and Feedback buttons (Closed)
Patch Set: Fix Mac build Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/sad_tab/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/sad_tab/sad_tab_view.mm
diff --git a/ios/chrome/browser/ui/sad_tab/sad_tab_view.mm b/ios/chrome/browser/ui/sad_tab/sad_tab_view.mm
index 793be20cc149bf89091a414e3950e62a828ae446..89e24dd73f2053badc7997a03dd697bae4a59555 100644
--- a/ios/chrome/browser/ui/sad_tab/sad_tab_view.mm
+++ b/ios/chrome/browser/ui/sad_tab/sad_tab_view.mm
@@ -4,9 +4,11 @@
#import "ios/chrome/browser/ui/sad_tab/sad_tab_view.h"
+#include "base/metrics/histogram_macros.h"
#include "base/strings/sys_string_conversions.h"
#include "components/grit/components_scaled_resources.h"
#include "components/strings/grit/components_strings.h"
+#include "components/ui_metrics/sadtab_metrics_types.h"
#include "ios/chrome/browser/chrome_url_constants.h"
#import "ios/chrome/browser/ui/colors/MDCPalette+CrAdditions.h"
#import "ios/chrome/browser/ui/commands/UIKit+ChromeExecuteCommand.h"
@@ -556,9 +558,15 @@ NSString* const kMessageTextViewBulletRTLFormat = @"\u202E%@\u202C";
- (void)handleActionButtonTapped:(id)sender {
switch (self.mode) {
case SadTabViewMode::RELOAD:
+ UMA_HISTOGRAM_ENUMERATION(ui_metrics::kSadTabReloadHistogramKey,
+ ui_metrics::SadTabEvent::BUTTON_CLICKED,
+ ui_metrics::SadTabEvent::MAX_SAD_TAB_EVENT);
self.navigationManager->Reload(web::ReloadType::NORMAL, true);
break;
case SadTabViewMode::FEEDBACK: {
+ UMA_HISTOGRAM_ENUMERATION(ui_metrics::kSadTabFeedbackHistogramKey,
+ ui_metrics::SadTabEvent::BUTTON_CLICKED,
+ ui_metrics::SadTabEvent::MAX_SAD_TAB_EVENT);
GenericChromeCommand* command =
[[GenericChromeCommand alloc] initWithTag:IDC_REPORT_AN_ISSUE];
[self chromeExecuteCommand:command];
« no previous file with comments | « ios/chrome/browser/ui/sad_tab/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698