Metrics logging for user engagement of the Reload and Feedback buttons

chrome/browser/ui/sad_tab.cc

Index: chrome/browser/ui/sad_tab.cc
diff --git a/chrome/browser/ui/sad_tab.cc b/chrome/browser/ui/sad_tab.cc
index 2a9d3b9365f6d615fa943d92d9cd6c5a1b61485e..8fb280c6e4cac165e24172abdc25f95c9b16b76d 100644
--- a/chrome/browser/ui/sad_tab.cc
+++ b/chrome/browser/ui/sad_tab.cc
@@ -16,6 +16,7 @@
 #include "chrome/grit/generated_resources.h"
 #include "components/feedback/feedback_util.h"
 #include "components/strings/grit/components_strings.h"
+#include "components/ui_metrics/sadtab_metrics_types.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/web_contents.h"
 #include "ui/base/l10n/l10n_util.h"
@@ -39,23 +40,13 @@ namespace {
     UMA_HISTOGRAM_COUNTS_1000(histogram_name, count); \
   }
 
-// This enum backs an UMA histogram, so it should be treated as append-only.
-// A Java counterpart will be generated for this enum.
-// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.tab
-enum SadTabEvent {
-  DISPLAYED,
-  BUTTON_CLICKED,
-  HELP_LINK_CLICKED,
-  MAX_SAD_TAB_EVENT
-};
-
-void RecordEvent(bool feedback, SadTabEvent event) {
+void RecordEvent(bool feedback, ui_metrics::SadTabEvent event) {
   if (feedback) {
-    UMA_HISTOGRAM_ENUMERATION("Tabs.SadTab.Feedback.Event", event,
-                              SadTabEvent::MAX_SAD_TAB_EVENT);
+    UMA_HISTOGRAM_ENUMERATION(ui_metrics::kSadTabFeedbackHistogramKey, event,
+                              ui_metrics::SadTabEvent::MAX_SAD_TAB_EVENT);
   } else {
-    UMA_HISTOGRAM_ENUMERATION("Tabs.SadTab.Reload.Event", event,
-                              SadTabEvent::MAX_SAD_TAB_EVENT);
+    UMA_HISTOGRAM_ENUMERATION(ui_metrics::kSadTabReloadHistogramKey, event,
+                              ui_metrics::SadTabEvent::MAX_SAD_TAB_EVENT);
   }
 }
 
@@ -224,14 +215,15 @@ void SadTab::RecordFirstPaint() {
       break;
   }
 
-  RecordEvent(show_feedback_button_, SadTabEvent::DISPLAYED);
+  RecordEvent(show_feedback_button_, ui_metrics::SadTabEvent::DISPLAYED);
 }
 
 void SadTab::PerformAction(SadTab::Action action) {
   DCHECK(recorded_paint_);
   switch (action) {
     case Action::BUTTON:
-      RecordEvent(show_feedback_button_, SadTabEvent::BUTTON_CLICKED);
+      RecordEvent(show_feedback_button_,
+                  ui_metrics::SadTabEvent::BUTTON_CLICKED);
       if (show_feedback_button_) {
         ShowFeedbackPage(
             FindBrowserWithWebContents(web_contents_),
@@ -246,7 +238,8 @@ void SadTab::PerformAction(SadTab::Action action) {
       }
       break;
     case Action::HELP_LINK:
-      RecordEvent(show_feedback_button_, SadTabEvent::HELP_LINK_CLICKED);
+      RecordEvent(show_feedback_button_,
+                  ui_metrics::SadTabEvent::HELP_LINK_CLICKED);
       content::OpenURLParams params(GURL(GetHelpLinkURL()), content::Referrer(),
                                     WindowOpenDisposition::CURRENT_TAB,
                                     ui::PAGE_TRANSITION_LINK, false);