Metrics logging for user engagement of the Reload and Feedback buttons

ui/base/ui_metrics_types.h

Index: ui/base/ui_metrics_types.h
diff --git a/ui/base/ui_metrics_types.h b/ui/base/ui_metrics_types.h
new file mode 100644
index 0000000000000000000000000000000000000000..619cd2ae356b45d8a527467ca682e619a21b6e7f
--- /dev/null
+++ b/ui/base/ui_metrics_types.h
@@ -0,0 +1,28 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_BASE_UI_METRICS_TYPES_H_
+#define UI_BASE_UI_METRICS_TYPES_H_
+
+namespace ui {

[sky, 2017/05/26 23:07:31]

Sorry for the bike shed.

The ui directory is intended for generic code used in building uis. From the
readme: "This directory contains UI frameworks used to build various user
interface features. This directory it not intended to contain UI features (such
as a keyboard)." (I realize ui/ is a bit of a mess now, hopefully that won't
last).

components was created as a place to share code between chrome and ios. Perhaps
that code should live there.

+// An enum for reporting interaction events to a UMA histogram.
+// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.tab
+enum class SadTabEvent {
+  // Records that the Sad Tab was displayed.
+  DISPLAYED = 0,
+  // Records that the main Sad Tab button was triggered.
+  BUTTON_CLICKED = 1,
+  // Records that the Sad Tab help link was triggered.
+  HELP_LINK_CLICKED = 2,
+  // Enum end marker.
+  MAX_SAD_TAB_EVENT = 3,
+};
+
+// Describes the mode of the Sad Tab as being in 'reload' mode.
+const char kSadTabReloadHistogramKey[] = "Tabs.SadTab.Reload.Event";
+// Describes the mode of the Sad Tab as being in 'feedback' mode.
+const char kSadTabFeedbackHistogramKey[] = "Tabs.SadTab.Feedback.Event";
+}
+
+#endif  // UI_BASE_UI_METRICS_TYPES_H_