Metrics logging for user engagement of the Reload and Feedback buttons

chrome/browser/ui/sad_tab.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/sad_tab.h"
 
 #include "base/metrics/histogram_macros.h"
 #include "base/time/time.h"
 #include "chrome/browser/net/referrer.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/chrome_pages.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/feedback/feedback_util.h"
 #include "components/strings/grit/components_strings.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/web_contents.h"
 #include "ui/base/l10n/l10n_util.h"
+#include "ui/base/ui_metrics_types.h"
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/memory/oom_memory_details.h"
 #endif
 
 namespace {
 
 // These stats should use the same counting approach and bucket size as tab
 // discard events in memory::OomPriorityManager so they can be directly
 // compared.
 
 // This macro uses a static counter to track how many times it's hit in a
 // session. See Tabs.SadTab.CrashCreated in histograms.xml for details.
 #define UMA_SAD_TAB_COUNTER(histogram_name)           \
   {                                                   \
     static int count = 0;                             \
     ++count;                                          \
     UMA_HISTOGRAM_COUNTS_1000(histogram_name, count); \
   }
 
-// This enum backs an UMA histogram, so it should be treated as append-only.
-// A Java counterpart will be generated for this enum.
-// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.tab
-enum SadTabEvent {
-  DISPLAYED,
-  BUTTON_CLICKED,
-  HELP_LINK_CLICKED,
-  MAX_SAD_TAB_EVENT
-};
-
-void RecordEvent(bool feedback, SadTabEvent event) {
+void RecordEvent(bool feedback, ui::SadTabEvent event) {
   if (feedback) {
-    UMA_HISTOGRAM_ENUMERATION("Tabs.SadTab.Feedback.Event", event,
-                              SadTabEvent::MAX_SAD_TAB_EVENT);
+    UMA_HISTOGRAM_ENUMERATION(ui::kSadTabFeedbackHistogramKey, event,
+                              ui::SadTabEvent::SAD_TAB_EVENT_MAX);
   } else {
-    UMA_HISTOGRAM_ENUMERATION("Tabs.SadTab.Reload.Event", event,
-                              SadTabEvent::MAX_SAD_TAB_EVENT);
+    UMA_HISTOGRAM_ENUMERATION(ui::kSadTabReloadHistogramKey, event,
+                              ui::SadTabEvent::SAD_TAB_EVENT_MAX);
   }
 }
 
 constexpr char kCategoryTagCrash[] = "Crash";
 
 bool ShouldShowFeedbackButton() {
 #if defined(GOOGLE_CHROME_BUILD)
   const int kMinSecondsBetweenCrashesForFeedbackButton = 10;
 
   static int64_t last_called_ts = 0;
@@ skipping 148 matching lines @@
 #if defined(OS_CHROMEOS)
     case chrome::SAD_TAB_KIND_KILLED_BY_OOM:
       UMA_SAD_TAB_COUNTER("Tabs.SadTab.KillDisplayed.OOM");
 #endif
     // Fallthrough
     case chrome::SAD_TAB_KIND_KILLED:
       UMA_SAD_TAB_COUNTER("Tabs.SadTab.KillDisplayed");
       break;
   }
 
-  RecordEvent(show_feedback_button_, SadTabEvent::DISPLAYED);
+  RecordEvent(show_feedback_button_, ui::SadTabEvent::SAD_TAB_EVENT_DISPLAYED);
 }
 
 void SadTab::PerformAction(SadTab::Action action) {
   DCHECK(recorded_paint_);
   switch (action) {
     case Action::BUTTON:
-      RecordEvent(show_feedback_button_, SadTabEvent::BUTTON_CLICKED);
+      RecordEvent(show_feedback_button_,
+                  ui::SadTabEvent::SAD_TAB_EVENT_BUTTON_CLICKED);
       if (show_feedback_button_) {
         ShowFeedbackPage(
             FindBrowserWithWebContents(web_contents_),
             kFeedbackSourceSadTabPage,
             l10n_util::GetStringUTF8(kind_ == SAD_TAB_KIND_CRASHED
                                          ? IDS_CRASHED_TAB_FEEDBACK_MESSAGE
                                          : IDS_KILLED_TAB_FEEDBACK_MESSAGE),
             std::string(kCategoryTagCrash));
       } else {
         web_contents_->GetController().Reload(content::ReloadType::NORMAL,
                                               true);
       }
       break;
     case Action::HELP_LINK:
-      RecordEvent(show_feedback_button_, SadTabEvent::HELP_LINK_CLICKED);
+      RecordEvent(show_feedback_button_,
+                  ui::SadTabEvent::SAD_TAB_EVENT_HELP_LINK_CLICKED);
       content::OpenURLParams params(GURL(GetHelpLinkURL()), content::Referrer(),
                                     WindowOpenDisposition::CURRENT_TAB,
                                     ui::PAGE_TRANSITION_LINK, false);
       web_contents_->OpenURL(params);
       break;
   }
 }
 
 SadTab::SadTab(content::WebContents* web_contents, SadTabKind kind)
     : web_contents_(web_contents),
@@ skipping 19 matching lines @@
     // Fall through
     case chrome::SAD_TAB_KIND_KILLED:
       UMA_SAD_TAB_COUNTER("Tabs.SadTab.KillCreated");
       LOG(WARNING) << "Tab Killed: "
                    << web_contents->GetURL().GetOrigin().spec();
       break;
   }
 }
 
 }  // namespace chrome