Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1221)

Unified Diff: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

Issue 2869203002: Cleanup around LocalFrame initialization (Closed)
Patch Set: +test fix Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
index 2aef3722eaac709e12a31a2d897c09d9d011cc1f..3368bbdab9a633f6322efc1d29a19498b129ee50 100644
--- a/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
@@ -333,15 +333,7 @@ WebLocalFrame* WebRemoteFrameImpl::CreateLocalChild(
RemoteFrameOwner* owner =
RemoteFrameOwner::Create(static_cast<SandboxFlags>(sandbox_flags),
container_policy, frame_owner_properties);
- // FIXME: currently this calls LocalFrame::init() on the created LocalFrame,
- // which may result in the browser observing two navigations to about:blank
- // (one from the initial frame creation, and one from swapping it into the
- // remote process). FrameLoader might need a special initialization function
- // for this case to avoid that duplicate navigation.
child->InitializeCoreFrame(*GetFrame()->GetPage(), owner, name);
- // Partially related with the above FIXME--the init() call may trigger JS
- // dispatch. However,
- // if the parent is remote, it should never be detached synchronously...
DCHECK(child->GetFrame());
return child;
}
« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698