third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.cpp - Issue 2869183002: Initial implementation of WorkletAnimation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.cpp

Issue 2869183002: Initial implementation of WorkletAnimation (Closed)

Patch Set: Rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.h ('k') | third_party/WebKit/Source/core/animation/WorkletAnimationBase.h » ('j') | third_party/WebKit/Source/core/animation/WorkletAnimationBase.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.cpp

diff --git a/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.cpp b/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.cpp

index b2b42cd88563ec3f5be4d764d043f55a49bf5cdd..59183784322c3466856a48af2208dc66cd11ca74 100644

--- a/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.cpp

+++ b/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.cpp

@@ -280,7 +280,8 @@ bool KeyframeEffectReadOnly::MaybeStartAnimationOnCompositor(

int group,

double start_time,

double current_time,

- double animation_playback_rate) {

+ double animation_playback_rate,

+ CompositorAnimationPlayer* compositor_player) {

DCHECK(!HasActiveAnimationsOnCompositor());

if (!IsCandidateForAnimationOnCompositor(animation_playback_rate))

return false;

@@ -288,7 +289,7 @@ bool KeyframeEffectReadOnly::MaybeStartAnimationOnCompositor(

return false;

CompositorAnimations::StartAnimationOnCompositor(

*target_, group, start_time, current_time, SpecifiedTiming(),

- *GetAnimation(), *Model(), compositor_animation_ids_,

+ GetAnimation(), compositor_player, *Model(), compositor_animation_ids_,

animation_playback_rate);

DCHECK(!compositor_animation_ids_.IsEmpty());

return true;