Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: third_party/WebKit/Source/core/animation/CompositorAnimations.cpp

Issue 2869183002: Initial implementation of WorkletAnimation (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/CompositorAnimations.cpp
diff --git a/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp b/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp
index 0ea349bd8cd5098f91caadc1ee70821a5d6a91d1..391409315bb04c46d85140a4d7adfffb6c4c4a50 100644
--- a/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp
+++ b/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp
@@ -377,13 +377,15 @@ void CompositorAnimations::StartAnimationOnCompositor(
double start_time,
double time_offset,
const Timing& timing,
- const Animation& animation,
+ const Animation* animation,
+ CompositorAnimationPlayer* compositor_player,
const EffectModel& effect,
Vector<int>& started_animation_ids,
double animation_playback_rate) {
+ DCHECK(compositor_player);
DCHECK(started_animation_ids.IsEmpty());
- DCHECK(IsCandidateForAnimationOnCompositor(timing, element, &animation,
- effect, animation_playback_rate));
+ DCHECK(IsCandidateForAnimationOnCompositor(timing, element, animation, effect,
+ animation_playback_rate));
DCHECK(CanStartAnimationOnCompositor(element));
const KeyframeEffectModelBase& keyframe_effect =
@@ -396,8 +398,6 @@ void CompositorAnimations::StartAnimationOnCompositor(
DCHECK(!animations.IsEmpty());
for (auto& compositor_animation : animations) {
int id = compositor_animation->Id();
- CompositorAnimationPlayer* compositor_player = animation.CompositorPlayer();
- DCHECK(compositor_player);
compositor_player->AddAnimation(std::move(compositor_animation));
started_animation_ids.push_back(id);
}

Powered by Google App Engine
This is Rietveld 408576698