third_party/WebKit/Source/modules/compositorworker/WorkletAnimation.idl - Issue 2869183002: Initial implementation of WorkletAnimation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/compositorworker/WorkletAnimation.idl

Issue 2869183002: Initial implementation of WorkletAnimation (Closed)

Patch Set: Fix include for new v8 bindings path Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/compositorworker/WorkletAnimation.cpp ('K') | « third_party/WebKit/Source/modules/compositorworker/WorkletAnimation.cpp ('k') | third_party/WebKit/Source/modules/modules_idl_files.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // https://wicg.github.io/animation-worklet/#worklet-animation-desc

	6

	7 [

	8 Constructor(DOMString animatorName,

	9 sequence<KeyframeEffectReadOnly> effects,

	10 sequence<(DocumentTimeline or ScrollTimeline)> timelines,
	flackr 2017/09/07 15:59:13 These construction parameters have become obsolete These construction parameters have become obsolete - we can take a single effect or sequence of effects and only a single timeline for now. We should at least have a TODO but if possible it'd be nice to match the spec parameters. smcgruer 2017/09/11 18:19:00 I was previously specifically told not to update t Show quoted text On 2017/09/07 15:59:13, flackr wrote: > These construction parameters have become obsolete - we can take a single effect > or sequence of effects and only a single timeline for now. We should at least > have a TODO but if possible it'd be nice to match the spec parameters. I was previously specifically told not to update these yet as the spec here was considered 'in flux'. Has that situation changed? Are we sure of the new construction parameters? Added a TODO for now at least.
	11 SerializedScriptValue options),

	12 RaisesException=Constructor,

	13 RuntimeEnabled=CompositorWorker

	14 ] interface WorkletAnimation {

	15 readonly attribute AnimationPlayState playState;

	16 void play();

	17 void cancel();

	18 };

OLD	NEW