Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 286913009: ash: Do a null-check for the screen-position client. (Closed)

Created:
6 years, 7 months ago by sadrul
Modified:
6 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, ben+ash_chromium.org
Visibility:
Public.

Description

ash: Do a null-check for the screen-position client. In a multi-monitor setup, when switching from extended mode to mirror mode, it is possible for the external monitor to receive events between when its RootWindowController is Shutdown()ed (which destroyes the screen-position client) and the root-window is destroyed. So make sure the client is there before trying to use it to convert the event's location to screen space. BUG=358266 R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271100

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M ash/wm/coordinate_conversion.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sadrul
6 years, 7 months ago (2014-05-16 17:43:24 UTC) #1
oshima
On 2014/05/16 17:43:24, sadrul wrote: I see. You might have affected by this cleanup. https://codereview.chromium.org/196573023 ...
6 years, 7 months ago (2014-05-16 19:13:05 UTC) #2
sadrul
6 years, 7 months ago (2014-05-16 21:31:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r271100 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698