Rebaseline invalid css2.1 tests

Rebaseline invalid css2.1 tests

In issue 308992 we adapted to the new SVG sizing behavior.
Unfortunately, the css testsuite hasn't yet adapted.

We have filed issues for this upstream:

http://test.csswg.org/shepherd/testcase/replaced-intrinsic-001/name/replaced-intrinsic/
http://test.csswg.org/shepherd/testcase/replaced-intrinsic-002/name/replaced-intrinsic/

Until the tests are addressed, rebaseline our test results to the new
behavior.

BUG=308992
TBR=ojan

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174271

[davve, 2014-05-16 14:16:39]

Is this a NOTRY=true candidate, perhaps?

[ojan, 2014-05-16 16:53:25]

This is fine, but the better way to do this for tests where you know all the
bots have cycled is to rebaseline it yourself. NeedsRebaseline is really only
useful because it saves you the work for making sure all the bots have cycled.
To do it yourself:

1. s/NeedsRebaseline/Rebaseline for the lines in question.
2. run webkit-patch rebaseline-expectations
3. Commit the resulting patch.

No need to get the patch reviewed. You can TBR commit it.

Under the covers, the rebaseline bot basically just does those steps. The
benefit of this is that it saves an unneeded commit going into the tree.

[davve, 2014-05-16 19:56:19]

On 2014/05/16 16:53:25, ojan wrote:
> This is fine, but the better way to do this for tests where you know all the
> bots have cycled is to rebaseline it yourself. NeedsRebaseline is really only
> useful because it saves you the work for making sure all the bots have cycled.
> To do it yourself:
> 
> 1. s/NeedsRebaseline/Rebaseline for the lines in question.
> 2. run webkit-patch rebaseline-expectations
> 3. Commit the resulting patch.
> 
> No need to get the patch reviewed. You can TBR commit it.
> 
> Under the covers, the rebaseline bot basically just does those steps. The
> benefit of this is that it saves an unneeded commit going into the tree.

Thanks for the instructions! I didn't know you could do this yourself.

FYI, I gave it a quick shot but ran into the following when attempting to git cl
upload. I get a feeling I shouldn't have to do such modifications for a simple
rebaseline, so perhaps something is up.

** Presubmit ERRORS **
check-webkit-style failed
 
LayoutTests/platform/android/css2.1/20110323/replaced-intrinsic-001-expected.png:0:
 Have to enable auto props in the subversion config file
(/Users/davve/.subversion/config "enable-auto-props = yes"). Have to set the
svn:mime-type in the subversion config file (/Users/davve/.subversion/config
"*.png = svn:mime-type=image/png").  [image/png] [5]
Total errors found: 1 in 7 files

Time to nap now but I'll give it another attempt at some time during the
weekend.

[ojan, 2014-05-16 20:01:29]

See the very last bullet point on
http://www.chromium.org/developers/coding-style for how to fix this. I really
should write up documentation about rebaselining tests. We have documentation,
but it's scattered in a bunch of places and it's mostly outdated from pre-Blink
fork.

[davve, 2014-05-19 08:19:55]

The CQ bit was checked by davve@opera.com

[commit-bot: I haz the power, 2014-05-19 08:20:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/davve@opera.com/286913007/20001

[commit-bot: I haz the power, 2014-05-19 08:20:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-19 08:20:11]

Failed to request the patch to try. Please note that binary files are still
unsupported at the moment, this is being worked on.

Thanks for your patience.

Transient error: Can't process patch for file
LayoutTests/platform/android/css2.1/20110323/replaced-intrinsic-001-expected.png.
Binary file is empty. Maybe the file wasn't uploaded in the first place?

[davve, 2014-05-19 08:37:01]

The CQ bit was checked by davve@opera.com

[commit-bot: I haz the power, 2014-05-19 08:37:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/davve@opera.com/286913007/30001

[commit-bot: I haz the power, 2014-05-19 12:12:49]

Change committed as 174271