android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java - Issue 2869103002: [Android WebView] Propagate Java exceptions thrown in OnReceivedSslError

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

Issue 2869103002: [Android WebView] Propagate Java exceptions thrown in OnReceivedSslError (Closed)

Patch Set: Add comments to ssl_manager.h as well. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/aw_contents_client_bridge.cc ('K') | « android_webview/browser/aw_contents_client_bridge_base.h ('k') | content/browser/ssl/ssl_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java b/android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

index a294913efc1270ead695e6a680faae6726f85b01..4d24f586033df9ff3f9199b63240e187f91dded3 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

@@ -163,7 +163,7 @@ public class AwContentsClientBridge {

// Unlike the webview classic, we do not keep keep a database of certificates that

// are allowed by the user, because this functionality is already handled via

// ssl_policy in native layers.

- @CalledByNative

+ @CalledByNativeUnchecked

private boolean allowCertificateError(int certError, byte[] derBytes, final String url,

final int id) {

final SslCertificate cert = SslUtil.getCertificateFromDerBytes(derBytes);