Chromium Code Reviews| Index: android_webview/browser/aw_content_browser_client.cc |
| diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc |
| index 9d2ad2555099ee4ed200f6716c2d610426ed67ea..137bb266d76b231fd39e22d3d55bd0a7f6da1ee9 100644 |
| --- a/android_webview/browser/aw_content_browser_client.cc |
| +++ b/android_webview/browser/aw_content_browser_client.cc |
| @@ -394,6 +394,7 @@ void AwContentBrowserClient::AllowCertificateError( |
| request_url, |
| callback, |
| &cancel_request); |
| + // TODO bail here on JNI exception ? Will we want to run the callback first? |
|
sgurun-gerrit only
2017/05/09 20:29:59
No you don't need to run.
gsennton
2017/05/11 12:17:16
Actually, I think we should explicitly avoid calli
|
| if (cancel_request) |
| callback.Run(content::CERTIFICATE_REQUEST_RESULT_TYPE_DENY); |
| } |