[Android WebView] Propagate Java exceptions thrown in OnReceivedSslError

content/browser/ssl/ssl_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SSL_SSL_MANAGER_H_
 #define CONTENT_BROWSER_SSL_SSL_MANAGER_H_
 
 #include <memory>
 #include <string>
 
@@ skipping 73 matching lines @@
   void DidDisplayMixedContent();
   void DidContainInsecureFormAction();
   void DidDisplayContentWithCertErrors();
   void DidShowPasswordInputOnHttp();
   void DidHideAllPasswordInputsOnHttp();
   void DidShowCreditCardInputOnHttp();
   void DidRunMixedContent(const GURL& security_origin);
   void DidRunContentWithCertErrors(const GURL& security_origin);
 
   // An error occurred with the certificate in an SSL connection.
+  //
+  // On Android, OnCertError can cause a Java exception to be thrown - in such a
+  // case we cannot allow calls back into Java after calling OnCertError. If
+  // adding code calling OnCertError, make sure it cannot call into Java after
+  // returning from OnCertError.
   void OnCertError(std::unique_ptr<SSLErrorHandler> handler);
 
  private:
   enum OnCertErrorInternalOptionsMask {
     OVERRIDABLE = 1 << 0,
     STRICT_ENFORCEMENT = 1 << 1,
     EXPIRED_PREVIOUS_DECISION = 1 << 2
   };
 
   // Helper method for handling certificate errors.
   //
   // Options should be a bitmask combination of OnCertErrorInternalOptionsMask.
   // OVERRIDABLE indicates whether or not the user could (assuming perfect
   // knowledge) successfully override the error and still get the security
   // guarantees of TLS. STRICT_ENFORCEMENT indicates whether or not the site the
   // user is trying to connect to has requested strict enforcement of
   // certificate validation (e.g. with HTTP Strict-Transport-Security).
   // EXPIRED_PREVIOUS_DECISION indicates whether a user decision had been
   // previously made but the decision has expired.
+  //
+  // On Android, OnCertErrorInternal can cause a Java exception to be thrown -
+  // in such a case we cannot allow calls back into Java after calling
+  // OnCertErrorInternal. If adding code calling OnCertErrorInternal, make sure
+  // it cannot call into Java after returning from OnCertErrorInternal.
   void OnCertErrorInternal(std::unique_ptr<SSLErrorHandler> handler,
                            int options_mask);
 
   // Updates the NavigationEntry's |content_status| flags according to
   // state in |ssl_host_state_delegate|. |add_content_status_flags| and
   // |remove_content_status_flags| are bitmasks of
   // SSLStatus::ContentStatusFlags that will be added or removed from
   // the |content_status| field. (Pass 0 to add/remove no content status
   // flags.) This method will notify the WebContents of an SSL state
   // change if a change was actually made.
@@ skipping 19 matching lines @@
 
   // Delegate that manages SSL state specific to each host.
   SSLHostStateDelegate* ssl_host_state_delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(SSLManager);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_SSL_SSL_MANAGER_H_