third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.insecure-parent-frame.html - Issue 2869093002: Upstream Service Worker window test to WPT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.insecure-parent-frame.html

Issue 2869093002: Upstream Service Worker window test to WPT

Patch Set: Incorporate review feedback Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/insecure-parent-window.html ('k') | third_party/WebKit/LayoutTests/http/tests/serviceworker/insecure-parent-frame.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.insecure-parent-frame.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/insecure-parent-frame.html b/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.insecure-parent-frame.html

similarity index 86%

rename from third_party/WebKit/LayoutTests/http/tests/serviceworker/insecure-parent-frame.html

rename to third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.insecure-parent-frame.html

index 98cdf66ffe3eb7fd27d78d3654bd89e218f06540..6aee5c18fdb3c00471412c869c1396c3bd7a2845 100644

--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/insecure-parent-frame.html

+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.insecure-parent-frame.html

@@ -1,4 +1,10 @@

<!DOCTYPE html>

+<!-- This test's file name is prefixed with `chromium.` because while a roughly

+ equivalent version is available in the Web Platform Tests project, the

+ limitations of the WPT infrastructure precludes the use of iframes for this

+ purpose. This version should be maintained only insofar as the functionality

+ under test concerns iframe contexts specifically; otherwise, modifications

+ should be contributed to the shared version. -->

@@ -40,7 +46,7 @@ promise_test(t => {

var scope = 'resources/insecure-inscope';

var registration;

var insecure_url = get_host_info().UNAUTHENTICATED_ORIGIN +

- '/serviceworker/resources/insecure-parent.html';

+ '/serviceworker/resources/insecure-parent-iframe.html';

var pre_registration_frame;

var post_registration_frame;