third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/insecure-parent.html - Issue 2869093002: Upstream Service Worker window test to WPT

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/insecure-parent.html

Issue 2869093002: Upstream Service Worker window test to WPT

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/insecure-inscope.html ('k') | third_party/WebKit/LayoutTests/http/tests/serviceworker/insecure-parent-frame.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <meta charset="utf-8">	2 <meta charset="utf-8">

3 <script src="../../resources/get-host-info.js?pipe=sub"></script>	3 <script src="/common/get-host-info.sub.js"></script>

4 <title>Page Title</title>	4 <title>Page Title</title>

5 <body></body>	5 <body></body>

6 <script>	6 <script>

7 var iframe = document.createElement('iframe');	7 var iframe = document.createElement('iframe');

8 iframe.src = get_host_info().HTTP_ORIGIN +	8 iframe.src = get_host_info().HTTP_ORIGIN +
	Marijn Kruisselbrink 2017/05/16 18:31:25 Is this the right origin? If I understand things c Is this the right origin? If I understand things correctly for the test to test what it tries to test this needs to be the same origin as what the main test script runs at, which I don't believe is HTTP_ORIGIN? falken 2017/05/17 05:47:56 Good catch, I think you're right. When I disable Show quoted text On 2017/05/16 18:31:25, Marijn Kruisselbrink wrote: > Is this the right origin? If I understand things correctly for the test to test > what it tries to test this needs to be the same origin as what the main test > script runs at, which I don't believe is HTTP_ORIGIN? Good catch, I think you're right. When I disable the parent frame security check in Blink (in ServiceWorkerNetworkProvider, set all instances of is_parent_frame_secure to true), this test still passes, while the original Chromium test fails. mike3 2017/05/18 15:48:00 Acknowledged. Show quoted text On 2017/05/16 18:31:25, Marijn Kruisselbrink wrote: > Is this the right origin? If I understand things correctly for the test to test > what it tries to test this needs to be the same origin as what the main test > script runs at, which I don't believe is HTTP_ORIGIN? Acknowledged.
9 '/serviceworker/resources/insecure-inscope.html';	9 '/service-workers/service-worker/resources/insecure-inscope.html';

10 document.body.appendChild(iframe);	10 document.body.appendChild(iframe);

11	11

	12 window.addEventListener('load', function() {

	13 opener.postMessage('loaded', '*');

	14 });

	15

12 // The top frame messages us to message the subframe.	16 // The top frame messages us to message the subframe.

13 window.addEventListener('message', e => {	17 window.addEventListener('message', e => {

14 iframe.contentWindow.postMessage(e.data, '*');	18 var target = e.source === opener ? iframe.contentWindow : opener;

	19 target.postMessage(e.data, '*');

15 });	20 });

16 </script>	21 </script>

OLD	NEW