Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart

Issue 2869083002: Convert server to use RangeFactory (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart
diff --git a/pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart b/pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart
index 5ba028e40852f99ccc3e65ad619a4dc0f517deb2..dd0be9305dcf899bde8f95cb07ce1e204ad7d63d 100644
--- a/pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart
+++ b/pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart
@@ -7,7 +7,6 @@ library services.src.refactoring.convert_method_to_getter;
import 'dart:async';
import 'package:analysis_server/src/protocol_server.dart' hide Element;
-import 'package:analysis_server/src/services/correction/source_range.dart';
import 'package:analysis_server/src/services/correction/status.dart';
import 'package:analysis_server/src/services/refactoring/refactoring.dart';
import 'package:analysis_server/src/services/refactoring/refactoring_internal.dart';
@@ -18,6 +17,7 @@ import 'package:analyzer/dart/element/element.dart';
import 'package:analyzer/src/dart/ast/utilities.dart';
import 'package:analyzer/src/dart/element/ast_provider.dart';
import 'package:analyzer/src/generated/source.dart';
+import 'package:analyzer_plugin/utilities/range_factory.dart';
/**
* [ConvertMethodToGetterRefactoring] implementation.
@@ -114,7 +114,7 @@ class ConvertMethodToGetterRefactoringImpl extends RefactoringImpl
}
// remove parameters
{
- SourceEdit edit = newSourceEdit_range(rangeNode(parameters), '');
+ SourceEdit edit = newSourceEdit_range(range.node(parameters), '');
doSourceChange_addElementEdit(change, element, edit);
}
}
@@ -136,8 +136,8 @@ class ConvertMethodToGetterRefactoringImpl extends RefactoringImpl
}
// we need invocation
if (invocation != null) {
- SourceRange range = rangeEndEnd(refRange, invocation);
- SourceEdit edit = newSourceEdit_range(range, '');
+ SourceEdit edit = newSourceEdit_range(
+ range.offsetEndIndex(refRange.end, invocation.end), '');
doSourceChange_addElementEdit(change, refElement, edit);
}
}

Powered by Google App Engine
This is Rietveld 408576698