Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2353)

Unified Diff: base/trace_event/process_memory_maps.cc

Issue 2869073002: Adding PE TimeStamp to chrome trace to ease retrieving debug information (Closed)
Patch Set: dcheng comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/trace_event/process_memory_maps.h ('k') | base/win/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/process_memory_maps.cc
diff --git a/base/trace_event/process_memory_maps.cc b/base/trace_event/process_memory_maps.cc
index a121239604074ebd2d4bfb4897f7b41fc46df03a..9d3421e69b21001738d97392b0654a95b297d04f 100644
--- a/base/trace_event/process_memory_maps.cc
+++ b/base/trace_event/process_memory_maps.cc
@@ -20,14 +20,14 @@ const uint32_t ProcessMemoryMaps::VMRegion::kProtectionFlagsMayshare = 128;
ProcessMemoryMaps::VMRegion::VMRegion()
: start_address(0),
size_in_bytes(0),
+ module_timestamp(0),
protection_flags(0),
byte_stats_private_dirty_resident(0),
byte_stats_private_clean_resident(0),
byte_stats_shared_dirty_resident(0),
byte_stats_shared_clean_resident(0),
byte_stats_swapped(0),
- byte_stats_proportional_resident(0) {
-}
+ byte_stats_proportional_resident(0) {}
ProcessMemoryMaps::VMRegion::VMRegion(const VMRegion& other) = default;
@@ -47,6 +47,8 @@ void ProcessMemoryMaps::AsValueInto(TracedValue* value) const {
value->SetString("sa", StringPrintf(kHexFmt, region.start_address));
value->SetString("sz", StringPrintf(kHexFmt, region.size_in_bytes));
+ if (region.module_timestamp)
+ value->SetString("ts", StringPrintf(kHexFmt, region.module_timestamp));
value->SetInteger("pf", region.protection_flags);
value->SetString("mf", region.mapped_file);
« no previous file with comments | « base/trace_event/process_memory_maps.h ('k') | base/win/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698