Adding PE TimeStamp to chrome trace to ease retrieving debug information

components/tracing/common/process_metrics_memory_dump_provider.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/tracing/common/process_metrics_memory_dump_provider.h"
 
 #include <fcntl.h>
 #include <stdint.h>
 
 #include <map>
 
 #include "base/files/file_util.h"
 #include "base/files/scoped_file.h"
 #include "base/format_macros.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
 #include "base/process/process_metrics.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/trace_event/memory_dump_manager.h"
 #include "base/trace_event/process_memory_dump.h"
 #include "base/trace_event/process_memory_maps.h"
 #include "base/trace_event/process_memory_totals.h"
+#include "base/win/pe_image.h"

[Primiano Tucci (use gerrit), 2017/05/09 16:34:01]

this needs to be under #if defined(OS_WIN) right?

[etienneb, 2017/05/09 17:39:31]

right.

 #include "build/build_config.h"
 
 #if defined(OS_MACOSX)
 #include <libproc.h>
 #include <mach/mach.h>
 #include <mach/mach_vm.h>
 #include <mach/shared_region.h>
 #include <sys/param.h>
 
 #include <mach-o/dyld_images.h>
@@ skipping 231 matching lines @@
 
     MODULEINFO module_info;
     if (!::GetModuleInformation(::GetCurrentProcess(), modules[i],
                                 &module_info, sizeof(MODULEINFO))) {
       continue;
     }
     base::trace_event::ProcessMemoryMaps::VMRegion region;
     region.size_in_bytes = module_info.SizeOfImage;
     region.mapped_file = base::SysWideToNativeMB(module_name);
     region.start_address = reinterpret_cast<uint64_t>(module_info.lpBaseOfDll);
+
+    // The PE header field |TimeDateStamp| is required to build the PE code
+    // identifier which is used as a key to query symbols servers.
+    base::win::PEImage pe_image(module_info.lpBaseOfDll);

[Primiano Tucci (use gerrit), 2017/05/09 16:34:01]

how long does this take? is it fine to keep doing this over and over? or should
we cache this?

[etienneb, 2017/05/09 17:39:31]

This is a trivial cost.
Roughly, the PE image is already in memory and this is just computing the offset
of a raw dword.

   TimeStamp = HMODULE[offset]

+    region.timestamp = pe_image.GetNTHeaders()->FileHeader.TimeDateStamp;
+
     pmd->process_mmaps()->AddVMRegion(region);
   }
   if (!pmd->process_mmaps()->vm_regions().empty())
     pmd->set_has_process_mmaps();
   return true;
 }
 #endif  // defined(OS_WIN)
 
 #if defined(OS_MACOSX)
 
@@ skipping 456 matching lines @@
 #endif
 }
 
 void ProcessMetricsMemoryDumpProvider::SuspendFastMemoryPolling() {
 #if defined(OS_LINUX) || defined(OS_ANDROID)
   fast_polling_statm_fd_.reset();
 #endif
 }
 
 }  // namespace tracing