Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2869043002: Store border-*-color on SurroundData in ComputedStyle not BorderColorAndStyle (Closed)
Patch Set: Fix a few issue Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
index 76494dc4ec00c89ce559781ab36aa1741870862d..a1baa78129a8f39146fbad36b115bf8229c0f8fb 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
@@ -886,7 +886,8 @@ bool ComputedStyle::DiffNeedsPaintInvalidationObject(
PrintColorAdjust() != other.PrintColorAdjust() ||
InsideLink() != other.InsideLink() ||
!Border().VisuallyEqual(other.Border()) || !RadiiEqual(other) ||
- !BorderSizeEquals(other) || *background_data_ != *other.background_data_)
+ !BorderColorEquals(other) || !BorderSizeEquals(other) ||
shend 2017/05/11 00:41:13 Is this necessary? Originally, we only compared Bo
nainar 2017/05/11 01:04:50 This is needed because VisuallyEqual used the Bord
+ *background_data_ != *other.background_data_)
return true;
if (rare_inherited_data_.Get() != other.rare_inherited_data_.Get()) {

Powered by Google App Engine
This is Rietveld 408576698