Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

Issue 2869043002: Store border-*-color on SurroundData in ComputedStyle not BorderColorAndStyle (Closed)
Patch Set: Always return VisitedDependantColor(CSSPropertyID) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
index 64a30c8ce86d6615fe4203866266608be207bc10..d9f82ce8abcee4716cf8d16155ba274af5860924 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
@@ -1957,6 +1957,26 @@ bool StyleResolver::HasAuthorBorder(const StyleResolverState& state) {
const CachedUAStyle* cached_ua_style = state.GetCachedUAStyle();
return cached_ua_style &&
(cached_ua_style->border != state.Style()->Border() ||
+ (cached_ua_style->border_left_color !=
+ state.Style()->VisitedDependentColor(
+ CSSPropertyBorderLeftColor) ||
+ cached_ua_style->border_right_color !=
+ state.Style()->VisitedDependentColor(
+ CSSPropertyBorderRightColor) ||
+ cached_ua_style->border_top_color !=
+ state.Style()->VisitedDependentColor(
+ CSSPropertyBorderTopColor) ||
+ cached_ua_style->border_bottom_color !=
+ state.Style()->VisitedDependentColor(
+ CSSPropertyBorderBottomColor)) ||
+ (cached_ua_style->border_left_color_is_current_color !=
+ state.Style()->BorderLeftColorIsCurrentColor() ||
+ cached_ua_style->border_right_color_is_current_color !=
+ state.Style()->BorderRightColorIsCurrentColor() ||
+ cached_ua_style->border_top_color_is_current_color !=
+ state.Style()->BorderTopColorIsCurrentColor() ||
+ cached_ua_style->border_bottom_color_is_current_color !=
+ state.Style()->BorderBottomColorIsCurrentColor()) ||
(cached_ua_style->border_left_width !=
state.Style()->BorderLeftWidth() ||
cached_ua_style->border_right_width !=

Powered by Google App Engine
This is Rietveld 408576698