PictureBenchmark JSON logging

bench/ResultsWriter.h

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  *
  * Classes for writing out bench results in various formats.
  */
 #ifndef SkResultsWriter_DEFINED
 #define SkResultsWriter_DEFINED
@@ skipping 83 matching lines @@
  *      {
  *      "name" : "Xfermode_Luminosity_640_480",
  *      "results" : [
  *         {
  *            "name": "565",
  *            "cmsecs" : 143.188128906250,
  *            "msecs" : 143.835957031250
  *         },
  *         ...
  */
+
+Json::Value* find_named_node(Json::Value* root, const char name[]);
 class JSONResultsWriter : public ResultsWriter {
-private:
-    Json::Value* find_named_node(Json::Value* root, const char name[]) {
-        Json::Value* search_results = NULL;
-        for(Json::Value::iterator iter = root->begin();
-                iter!= root->end(); ++iter) {
-            if(SkString(name).equals((*iter)["name"].asCString())) {
-                search_results = &(*iter);
-                break;
-            }
-        }
-
-        if(search_results != NULL) {
-            return search_results;
-        } else {
-            Json::Value* new_val = &(root->append(Json::Value()));
-            (*new_val)["name"] = name;
-            return new_val;
-        }
-    }
 public:
     explicit JSONResultsWriter(const char filename[])
         : fFilename(filename)
         , fRoot()
         , fResults(fRoot["results"])
         , fBench(NULL)
         , fConfig(NULL) {
     }
     virtual void option(const char name[], const char value[]) {
         fRoot["options"][name] = value;
@@ skipping 22 matching lines @@
     }
 private:
 
     SkString fFilename;
     Json::Value fRoot;
     Json::Value& fResults;
     Json::Value* fBench;
     Json::Value* fConfig;
 };
 
+
+Json::Value* find_named_node(Json::Value* root, const char name[]) {

[jcgregorio, 2014/05/27 15:34:25]

Should be moved to a CPP file. Also I believe the naming convention for externed
static functions is camel caps:


https://sites.google.com/site/skiadocs/developer-documentation/contributing-c...

[kelvinly, 2014/05/27 16:41:06]

Ah, sorry. Any advice on what to name the CPP file?

[jcgregorio, 2014/05/27 17:14:05]

ResultsWriter.cpp

On 2014/05/27 16:41:06, kelvinly wrote:

[kelvinly, 2014/05/27 18:55:28]

Done.

+    Json::Value* search_results = NULL;
+    for(Json::Value::iterator iter = root->begin();
+            iter!= root->end(); ++iter) {
+        if(SkString(name).equals((*iter)["name"].asCString())) {
+            search_results = &(*iter);
+            break;
+        }
+    }
+
+    if(search_results != NULL) {
+        return search_results;
+    } else {
+        Json::Value* new_val = &(root->append(Json::Value()));
+        (*new_val)["name"] = name;
+        return new_val;
+    }
+}
 #endif // SK_BUILD_JSON_WRITER
+
 /**
  * This ResultsWriter writes out to multiple ResultsWriters.
  */
 class MultiResultsWriter : public ResultsWriter {
 public:
     MultiResultsWriter() : writers() {
     };
     void add(ResultsWriter* writer) {
       writers.push_back(writer);
     }
@@ skipping 31 matching lines @@
  */
 template <typename T> class CallEnd : SkNoncopyable {
 public:
     CallEnd(T& obj) : fObj(obj) {}
     ~CallEnd() { fObj.end(); }
 private:
     T&  fObj;
 };
 
 #endif