Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: Source/core/css/RuleFeature.cpp

Issue 286903024: Skip child ShadowRoots when invalidation does not have boundary crossing rules (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix build Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/RuleFeature.h ('k') | Source/core/css/invalidation/DescendantInvalidationSet.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/RuleFeature.cpp
diff --git a/Source/core/css/RuleFeature.cpp b/Source/core/css/RuleFeature.cpp
index 6adb2dc6fcfdb6c2da48c0f0d9dc3528d7449be8..5e687d8fc44904f0e903dd10125386f6444d80cd 100644
--- a/Source/core/css/RuleFeature.cpp
+++ b/Source/core/css/RuleFeature.cpp
@@ -207,41 +207,50 @@ RuleFeatureSet::InvalidationSetMode RuleFeatureSet::updateInvalidationSets(const
return mode;
InvalidationSetFeatures features;
- const CSSSelector* current = extractInvalidationSetFeatures(selector, features);
- if (current) {
- bool wholeSubtree = current->relation() == CSSSelector::DirectAdjacent || current->relation() == CSSSelector::IndirectAdjacent;
- current = current->tagHistory();
- if (current)
- addFeaturesToInvalidationSets(*current, features, wholeSubtree);
- }
+ if (const CSSSelector* current = extractInvalidationSetFeatures(selector, features))
+ addFeaturesToInvalidationSets(*current, features);
return AddFeatures;
}
const CSSSelector* RuleFeatureSet::extractInvalidationSetFeatures(const CSSSelector& selector, InvalidationSetFeatures& features)
{
- const CSSSelector* lastSelector = &selector;
- for (; lastSelector; lastSelector = lastSelector->tagHistory()) {
- extractInvalidationSetFeature(*lastSelector, features);
+ for (const CSSSelector* current = &selector; current; current = current->tagHistory()) {
+ extractInvalidationSetFeature(*current, features);
// Initialize the entry in the invalidation set map, if supported.
- invalidationSetForSelector(*lastSelector);
- if (lastSelector->pseudoType() == CSSSelector::PseudoHost || lastSelector->pseudoType() == CSSSelector::PseudoAny) {
- if (const CSSSelectorList* selectorList = lastSelector->selectorList()) {
+ invalidationSetForSelector(*current);
+ if (current->pseudoType() == CSSSelector::PseudoHost || current->pseudoType() == CSSSelector::PseudoAny) {
+ if (const CSSSelectorList* selectorList = current->selectorList()) {
for (const CSSSelector* selector = selectorList->first(); selector; selector = CSSSelectorList::next(*selector))
extractInvalidationSetFeatures(*selector, features);
}
}
- if (lastSelector->relation() != CSSSelector::SubSelector)
+ switch (current->relation()) {
+ case CSSSelector::SubSelector:
break;
+ case CSSSelector::ShadowPseudo:
+ case CSSSelector::ShadowDeep:
+ features.treeBoundaryCrossing = true;
+ return current->tagHistory();
+ case CSSSelector::DirectAdjacent:
+ case CSSSelector::IndirectAdjacent:
+ features.wholeSubtree = true;
+ return current->tagHistory();
+ case CSSSelector::Descendant:
+ case CSSSelector::Child:
+ return current->tagHistory();
+ }
}
- return lastSelector;
+ return 0;
}
-void RuleFeatureSet::addFeaturesToInvalidationSets(const CSSSelector& selector, const InvalidationSetFeatures& features, bool wholeSubtree)
+void RuleFeatureSet::addFeaturesToInvalidationSets(const CSSSelector& selector, InvalidationSetFeatures& features)
{
for (const CSSSelector* current = &selector; current; current = current->tagHistory()) {
if (DescendantInvalidationSet* invalidationSet = invalidationSetForSelector(*current)) {
- if (wholeSubtree) {
+ if (features.treeBoundaryCrossing)
+ invalidationSet->setTreeBoundaryCrossing();
+ if (features.wholeSubtree) {
invalidationSet->setWholeSubtreeInvalid();
} else {
if (!features.id.isEmpty())
@@ -256,27 +265,28 @@ void RuleFeatureSet::addFeaturesToInvalidationSets(const CSSSelector& selector,
invalidationSet->setCustomPseudoInvalid();
}
} else if (current->pseudoType() == CSSSelector::PseudoHost || current->pseudoType() == CSSSelector::PseudoAny) {
+ if (current->pseudoType() == CSSSelector::PseudoHost)
+ features.treeBoundaryCrossing = true;
if (const CSSSelectorList* selectorList = current->selectorList()) {
for (const CSSSelector* selector = selectorList->first(); selector; selector = CSSSelectorList::next(*selector))
- addFeaturesToInvalidationSets(*selector, features, wholeSubtree);
+ addFeaturesToInvalidationSets(*selector, features);
}
}
switch (current->relation()) {
- case CSSSelector::Descendant:
- case CSSSelector::Child:
+ case CSSSelector::SubSelector:
+ break;
case CSSSelector::ShadowPseudo:
case CSSSelector::ShadowDeep:
- wholeSubtree = false;
+ features.treeBoundaryCrossing = true;
+ features.wholeSubtree = false;
+ break;
+ case CSSSelector::Descendant:
+ case CSSSelector::Child:
+ features.wholeSubtree = false;
break;
case CSSSelector::DirectAdjacent:
case CSSSelector::IndirectAdjacent:
- wholeSubtree = true;
- break;
- case CSSSelector::SubSelector:
- break;
- default:
- // All combinators should be handled above.
- ASSERT_NOT_REACHED();
+ features.wholeSubtree = true;
break;
}
}
« no previous file with comments | « Source/core/css/RuleFeature.h ('k') | Source/core/css/invalidation/DescendantInvalidationSet.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698