Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 286903022: Revert of Remove override of View::HitTestRect() from ImageView (Closed)

Created:
6 years, 7 months ago by tdanderson
Modified:
6 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Revert of Remove override of View::HitTestRect() from ImageView (https://codereview.chromium.org/282403002/) Reason for revert: Breaks mouse hover on image buttons (see https://code.google.com/p/chromium/issues/detail?id=376478). tdanderson@ will investigate. Original issue's description: > Remove override of View::HitTestRect() from ImageView > > The override of View::HitTestRect() in ImageView forces hit > testing to fail if the |interactive_| member is false, which > prevents the view from accepting events. Since the |interactive_| > member is unrelated to location, it is better to move this logic > into an override of EventTarget::CanAcceptEvent() instead. > > BUG=374325 > TEST=none > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272117 TBR=sadrul@chromium.org NOTREECHECKS=true NOTRY=true BUG=374325

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M ui/views/controls/image_view.h View 1 chunk +1 line, -3 lines 0 comments Download
M ui/views/controls/image_view.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tdanderson
Created Revert of Remove override of View::HitTestRect() from ImageView
6 years, 7 months ago (2014-05-22 20:59:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/286903022/1
6 years, 7 months ago (2014-05-22 21:02:00 UTC) #2
tdanderson
The CQ bit was unchecked by tdanderson@chromium.org
6 years, 7 months ago (2014-05-22 21:02:44 UTC) #3
tdanderson
6 years, 7 months ago (2014-05-22 21:03:06 UTC) #4
Message was sent while issue was closed.
On 2014/05/22 20:59:52, tdanderson wrote:
> Created Revert of Remove override of View::HitTestRect() from ImageView

erg@ beat me to it: https://codereview.chromium.org/296703012/

Powered by Google App Engine
This is Rietveld 408576698