Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 286903005: [reland] Remove SandboxBPF's dependency on CompatibilityPolicy (Closed)

Created:
6 years, 7 months ago by mdempsky
Modified:
6 years, 7 months ago
CC:
chromium-reviews, agl, jln+watch_chromium.org, Ilya Sherman, earthdok
Visibility:
Public.

Description

[reland] Remove SandboxBPF's dependency on CompatibilityPolicy SandboxBPF users are now required to always provide a SandboxBPFPolicy instead of a SyscallEvaluator. CompatibilityPolicy can't be removed just yet though because it's still used by the deprecated BPF_TEST macros. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271814

Patch Set 1 #

Patch Set 2 : Initialize pid on the stack #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -104 lines) Patch
M sandbox/linux/seccomp-bpf/demo.cc View 3 chunks +15 lines, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf/sandbox_bpf.h View 3 chunks +1 line, -24 lines 0 comments Download
M sandbox/linux/seccomp-bpf/sandbox_bpf.cc View 7 chunks +38 lines, -32 lines 0 comments Download
M sandbox/linux/seccomp-bpf/sandbox_bpf_unittest.cc View 1 4 chunks +66 lines, -46 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mdempsky
Patch set 1 is the originally committed patch, patch set 2 is the fixed one. ...
6 years, 7 months ago (2014-05-20 15:49:06 UTC) #1
mdempsky
On 2014/05/20 15:49:06, mdempsky wrote: > Patch set 1 is the originally committed patch, patch ...
6 years, 7 months ago (2014-05-20 15:57:57 UTC) #2
jln (very slow on Chromium)
lgtm
6 years, 7 months ago (2014-05-20 18:50:17 UTC) #3
mdempsky
The CQ bit was checked by mdempsky@chromium.org
6 years, 7 months ago (2014-05-20 18:50:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mdempsky@chromium.org/286903005/20001
6 years, 7 months ago (2014-05-20 18:52:21 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 02:17:21 UTC) #6
Message was sent while issue was closed.
Change committed as 271814

Powered by Google App Engine
This is Rietveld 408576698