Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: src/debug.cc

Issue 286903003: Remove unused thread locals from debugger. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug.h ('k') | src/ia32/frames-ia32.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug.cc
diff --git a/src/debug.cc b/src/debug.cc
index a994eb008511c44574ade6986d6463ea53f1c70e..b13a1631573b2aa3db7bb26e4a302bcc9317ce72 100644
--- a/src/debug.cc
+++ b/src/debug.cc
@@ -40,7 +40,6 @@ Debug::Debug(Isolate* isolate)
promise_catch_handlers_(0),
promise_getters_(0),
isolate_(isolate) {
- memset(registers_, 0, sizeof(JSCallerSavedBuffer));
ThreadInit();
}
@@ -518,10 +517,7 @@ void Debug::ThreadInit() {
char* Debug::ArchiveDebug(char* storage) {
char* to = storage;
OS::MemCopy(to, reinterpret_cast<char*>(&thread_local_), sizeof(ThreadLocal));
- to += sizeof(ThreadLocal);
- OS::MemCopy(to, reinterpret_cast<char*>(&registers_), sizeof(registers_));
ThreadInit();
- ASSERT(to <= storage + ArchiveSpacePerThread());
return storage + ArchiveSpacePerThread();
}
@@ -530,15 +526,12 @@ char* Debug::RestoreDebug(char* storage) {
char* from = storage;
OS::MemCopy(
reinterpret_cast<char*>(&thread_local_), from, sizeof(ThreadLocal));
- from += sizeof(ThreadLocal);
- OS::MemCopy(reinterpret_cast<char*>(&registers_), from, sizeof(registers_));
- ASSERT(from <= storage + ArchiveSpacePerThread());
return storage + ArchiveSpacePerThread();
}
int Debug::ArchiveSpacePerThread() {
- return sizeof(ThreadLocal) + sizeof(JSCallerSavedBuffer);
+ return sizeof(ThreadLocal);
}
« no previous file with comments | « src/debug.h ('k') | src/ia32/frames-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698