Clean up type inference methods.

Clean up type inference methods.

Several minor changes that shouldn't affect functionality:

- inferGenericFunctionOrType no longer returns the inferred type;
  instead, it fills an "inferredTypes" array with the inferred type
  arguments.

- Downwards inference is signaled to inferGenericFunctionOrType by
  passing `null` for `formalTypes` and `actualTypes`.

- inferTypeFromConstraints no longer falls back on
  instantiateToBounds.  This never could have had any effect anyway
  because it was only invoked for upwards inference, and in that case,
  all type arguments are already known.

- Inferred type arguments are now passed back to
  KernelConstructorInvocation as a list rather than forcing it to
  extract them from the inferred class type.  If the inferred class
  type doesn't need to be computed, it isn't.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/6b9b2146ed8f202e815e8c08034c27eaf84ce2bc

[Paul Berry, 2017-05-08 23:23:24]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-05-08 23:36:14]

LGTM

[Paul Berry, 2017-05-09 12:52:45]

Description was changed from

==========
Clean up type inference methods.

Several minor changes that shouldn't affect functionality:

- inferGenericFunctionOrType no longer returns the inferred type;
  instead, it fills an "inferredTypes" array with the inferred type
  arguments.

- Downwards inference is signaled to inferGenericFunctionOrType by
  passing `null` for `formalTypes` and `actualTypes`.

- inferTypeFromConstraints no longer falls back on
  instantiateToBounds.  This never could have had any effect anyway
  because it was only invoked for upwards inference, and in that case,
  all type arguments are already known.

- Inferred type arguments are now passed back to
  KernelConstructorInvocation as a list rather than forcing it to
  extract them from the inferred class type.  If the inferred class
  type doesn't need to be computed, it isn't.
==========

to

==========
Clean up type inference methods.

Several minor changes that shouldn't affect functionality:

- inferGenericFunctionOrType no longer returns the inferred type;
  instead, it fills an "inferredTypes" array with the inferred type
  arguments.

- Downwards inference is signaled to inferGenericFunctionOrType by
  passing `null` for `formalTypes` and `actualTypes`.

- inferTypeFromConstraints no longer falls back on
  instantiateToBounds.  This never could have had any effect anyway
  because it was only invoked for upwards inference, and in that case,
  all type arguments are already known.

- Inferred type arguments are now passed back to
  KernelConstructorInvocation as a list rather than forcing it to
  extract them from the inferred class type.  If the inferred class
  type doesn't need to be computed, it isn't.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6b9b2146ed8f202e815e8c08034c27eaf84ce2bc
==========

[Paul Berry, 2017-05-09 12:52:46]

Committed patchset #1 (id:1) manually as
6b9b2146ed8f202e815e8c08034c27eaf84ce2bc (presubmit successful).