Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Unified Diff: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc

Issue 2868983003: Ensure History > Recent Tabs restore preserves window disposition. (Closed)
Patch Set: Remove NOTREACHED(). Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_live_tab_context.cc ('k') | components/sessions/core/live_tab_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc
diff --git a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc
index aaac0456e74576a42635edea8511d39e49862da9..bdd1d2e27112a3678b286b3cb13b26349a292a47 100644
--- a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc
+++ b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc
@@ -464,6 +464,10 @@ void RecentTabsSubMenuModel::BuildLocalEntries() {
break;
}
case sessions::TabRestoreService::WINDOW: {
+ // TODO(chrisha): Make this menu entry better. When windows contain a
+ // single tab, display that tab directly in the menu. Otherwise, offer
+ // a hover over or alternative mechanism for seeing which tabs were in
+ // the window.
BuildLocalWindowItem(
entry->id,
static_cast<const sessions::TabRestoreService::Window&>(*entry)
« no previous file with comments | « chrome/browser/ui/browser_live_tab_context.cc ('k') | components/sessions/core/live_tab_context.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698