Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1824)

Unified Diff: chrome/browser/ui/android/tab_model/android_live_tab_context.cc

Issue 2868983003: Ensure History > Recent Tabs restore preserves window disposition. (Closed)
Patch Set: Minor cleanup. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/tab_model/android_live_tab_context.cc
diff --git a/chrome/browser/ui/android/tab_model/android_live_tab_context.cc b/chrome/browser/ui/android/tab_model/android_live_tab_context.cc
index 73740024ea894e4a9d2b34dda825fe2274f40e5f..6e152f2967820e8b95a53a2520f2efb9fa7c38aa 100644
--- a/chrome/browser/ui/android/tab_model/android_live_tab_context.cc
+++ b/chrome/browser/ui/android/tab_model/android_live_tab_context.cc
@@ -32,7 +32,7 @@ int AndroidLiveTabContext::GetSelectedIndex() const {
return tab_model_->GetActiveIndex();
}
-// Not supported by android.
+// Not applicable to android.
std::string AndroidLiveTabContext::GetAppName() const {
return std::string();
}
@@ -54,11 +54,26 @@ sessions::LiveTab* AndroidLiveTabContext::GetActiveLiveTab() const {
return sessions::ContentLiveTab::GetForWebContents(web_contents);
}
-// Not supported by android.
+// Not applicable to android.
sky 2017/06/28 22:38:00 optional: move comments inside implementation.
chrisha 2017/06/30 15:42:12 Done.
bool AndroidLiveTabContext::IsTabPinned(int index) const {
return false;
}
+// Not applicable to android.
+const gfx::Rect AndroidLiveTabContext::GetBounds() const {
+ return gfx::Rect();
+}
+
+// Not applicable to android.
+ui::WindowShowState AndroidLiveTabContext::GetShowState() const {
+ return ui::SHOW_STATE_NORMAL;
+}
+
+// Not applicable to android.
+std::string AndroidLiveTabContext::GetWorkspace() const {
+ return std::string();
+}
+
sessions::LiveTab* AndroidLiveTabContext::AddRestoredTab(
const std::vector<sessions::SerializedNavigationEntry>& navigations,
int tab_index,

Powered by Google App Engine
This is Rietveld 408576698