Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: chrome/browser/ui/android/tab_model/android_live_tab_context.cc

Issue 2868983003: Ensure History > Recent Tabs restore preserves window disposition. (Closed)
Patch Set: More iOS fixes. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/tab_model/android_live_tab_context.cc
diff --git a/chrome/browser/ui/android/tab_model/android_live_tab_context.cc b/chrome/browser/ui/android/tab_model/android_live_tab_context.cc
index 73740024ea894e4a9d2b34dda825fe2274f40e5f..5a9ba2998e72ab80ccea458f96cb03b24829cec7 100644
--- a/chrome/browser/ui/android/tab_model/android_live_tab_context.cc
+++ b/chrome/browser/ui/android/tab_model/android_live_tab_context.cc
@@ -59,6 +59,21 @@ bool AndroidLiveTabContext::IsTabPinned(int index) const {
return false;
}
+// Not supported by android.
sky 2017/05/12 02:42:06 supported->applicable to?
chrisha 2017/06/28 18:30:42 I was copy-pasting similar comments from in this f
+const gfx::Rect AndroidLiveTabContext::GetBounds() const {
+ return gfx::Rect();
+}
+
+// Not supported by android.
+ui::WindowShowState AndroidLiveTabContext::GetShowState() const {
+ return ui::SHOW_STATE_NORMAL;
+}
+
+// Not supported by android.
+std::string AndroidLiveTabContext::GetWorkspace() const {
+ return "";
sky 2017/05/12 02:42:06 "" -> std::string()
chrisha 2017/06/28 18:30:42 Done.
+}
+
sessions::LiveTab* AndroidLiveTabContext::AddRestoredTab(
const std::vector<sessions::SerializedNavigationEntry>& navigations,
int tab_index,

Powered by Google App Engine
This is Rietveld 408576698