Ensure History > Recent Tabs restore preserves window disposition.

ios/chrome/browser/sessions/ios_chrome_tab_restore_service_client.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ios/chrome/browser/sessions/ios_chrome_tab_restore_service_client.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "components/sessions/ios/ios_live_tab.h"
 #include "ios/chrome/browser/application_context.h"
@@ skipping 53 matching lines @@
 }  // namespace
 
 IOSChromeTabRestoreServiceClient::IOSChromeTabRestoreServiceClient(
     ios::ChromeBrowserState* browser_state)
     : browser_state_(browser_state) {}
 
 IOSChromeTabRestoreServiceClient::~IOSChromeTabRestoreServiceClient() {}
 
 sessions::LiveTabContext*
 IOSChromeTabRestoreServiceClient::CreateLiveTabContext(
-    const std::string& app_name) {
+    const std::string& unused_app_name,

[sky, 2017/07/11 20:28:09]

Parameters should match that of the header.

[chrisha, 2017/08/14 14:43:21]

I'm generally in favor of that, but I suppose I see it as clear documentation
that the indicated parameters are being ignored. From the style guide they say
to use the same parameter names, but to comment them out:

https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_D...

+    const gfx::Rect& unused_bounds,
+    ui::WindowShowState unused_show_state,
+    const std::string& unused_workspace) {
   return TabRestoreServiceDelegateImplIOSFactory::GetForBrowserState(
       browser_state_);
 }
 
 sessions::LiveTabContext*
 IOSChromeTabRestoreServiceClient::FindLiveTabContextForTab(
     const sessions::LiveTab* tab) {
   const sessions::IOSLiveTab* requested_tab =
       static_cast<const sessions::IOSLiveTab*>(tab);
 
@@ skipping 51 matching lines @@
 
 bool IOSChromeTabRestoreServiceClient::HasLastSession() {
   return false;
 }
 
 void IOSChromeTabRestoreServiceClient::GetLastSession(
     const sessions::GetLastSessionCallback& callback,
     base::CancelableTaskTracker* tracker) {
   NOTREACHED();
 }