Ensure History > Recent Tabs restore preserves window disposition.

chrome/browser/sessions/persistent_tab_restore_service_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/sessions/core/persistent_tab_restore_service.h"
 
 #include <stddef.h>
 
 #include <string>
 #include <utility>
@@ skipping 60 matching lines @@
       url2_("http://2"),
       url3_("http://3"),
       user_agent_override_(
           "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/535.19"
           " (KHTML, like Gecko) Chrome/18.0.1025.45 Safari/535.19"),
       time_factory_(NULL) {
   }
 
   ~PersistentTabRestoreServiceTest() override {}
 
+  SessionID tab_id() { return tab_id_; }

[sky, 2017/06/28 22:38:00]

const on both these. That is:
SessionID tab_id() const

[chrisha, 2017/06/30 15:42:12]

Done.

+  SessionID window_id() { return window_id_; }
+
  protected:
   enum {
     kMaxEntries = sessions::TabRestoreServiceHelper::kMaxEntries,
   };
 
   // testing::Test:
   void SetUp() override {
     ChromeRenderViewHostTestHarness::SetUp();
     live_tab_ = base::WrapUnique(new sessions::ContentLiveTab(web_contents()));
     time_factory_ = new PersistentTabRestoreTimeFactory();
@@ skipping 41 matching lines @@
         base::MakeUnique<ChromeTabRestoreServiceClient>(profile()),
         time_factory_));
     SynchronousLoadTabsFromLastSession();
   }
 
   // Adds a window with one tab and url to the profile's session service.
   // If |pinned| is true, the tab is marked as pinned in the session service.
   void AddWindowWithOneTabToSessionService(bool pinned) {
     SessionService* session_service =
         SessionServiceFactory::GetForProfile(profile());
-    SessionID tab_id;
-    SessionID window_id;
-    session_service->SetWindowType(window_id,
-                                   Browser::TYPE_TABBED,
+    session_service->SetWindowType(window_id(), Browser::TYPE_TABBED,
                                    SessionService::TYPE_NORMAL);
-    session_service->SetTabWindow(window_id, tab_id);
-    session_service->SetTabIndexInWindow(window_id, tab_id, 0);
-    session_service->SetSelectedTabInWindow(window_id, 0);
+    session_service->SetTabWindow(window_id(), tab_id());
+    session_service->SetTabIndexInWindow(window_id(), tab_id(), 0);
+    session_service->SetSelectedTabInWindow(window_id(), 0);
     if (pinned)
-      session_service->SetPinnedState(window_id, tab_id, true);
+      session_service->SetPinnedState(window_id(), tab_id(), true);
     session_service->UpdateTabNavigation(
-        window_id, tab_id,
-        SerializedNavigationEntryTestHelper::CreateNavigation(
-            url1_.spec(), "title"));
+        window_id(), tab_id(),
+        SerializedNavigationEntryTestHelper::CreateNavigation(url1_.spec(),
+                                                              "title"));
   }
 
   // Creates a SessionService and assigns it to the Profile. The SessionService
   // is configured with a single window with a single tab pointing at url1_ by
   // way of AddWindowWithOneTabToSessionService. If |pinned| is true, the
   // tab is marked as pinned in the session service.
   void CreateSessionServiceWithOneWindow(bool pinned) {
     std::unique_ptr<SessionService> session_service(
         new SessionService(profile()));
     SessionServiceFactory::SetForTestProfile(profile(),
@@ skipping 13 matching lines @@
 
   sessions::LiveTab* live_tab() { return live_tab_.get(); }
 
   GURL url1_;
   GURL url2_;
   GURL url3_;
   std::string user_agent_override_;
   std::unique_ptr<sessions::LiveTab> live_tab_;
   std::unique_ptr<sessions::PersistentTabRestoreService> service_;
   PersistentTabRestoreTimeFactory* time_factory_;
+  SessionID window_id_;
+  SessionID tab_id_;
 };
 
 namespace {
 
 class TestTabRestoreServiceObserver
     : public sessions::TabRestoreServiceObserver {
  public:
   TestTabRestoreServiceObserver() : got_loaded_(false) {}
 
   void clear_got_loaded() { got_loaded_ = false; }
@@ skipping 282 matching lines @@
   ASSERT_FALSE(tab->pinned);
   ASSERT_EQ(3U, tab->navigations.size());
   EXPECT_EQ(2, tab->current_navigation_index);
   EXPECT_EQ(time_factory_->TimeNow().ToInternalValue(),
             tab->timestamp.ToInternalValue());
   EXPECT_TRUE(url1_ == tab->navigations[0].virtual_url());
   EXPECT_TRUE(url2_ == tab->navigations[1].virtual_url());
   EXPECT_TRUE(url3_ == tab->navigations[2].virtual_url());
 }
 
+// Make sure window bounds and workspace are properly loaded from the session
+// service.
+TEST_F(PersistentTabRestoreServiceTest, LoadWindowBoundsAndWorkspace) {
+  static constexpr gfx::Rect kBounds(10, 20, 640, 480);

[sky, 2017/06/28 22:38:00]

Remove static from these.

[chrisha, 2017/06/30 15:42:12]

Done.

+  static constexpr ui::WindowShowState kShowState = ui::SHOW_STATE_MINIMIZED;
+  static constexpr char kWorkspace[] = "workspace";
+
+  CreateSessionServiceWithOneWindow(false);
+
+  // Set the bounds, show state and workspace.
+  SessionService* session_service =
+      SessionServiceFactory::GetForProfile(profile());
+  session_service->SetWindowBounds(window_id(), kBounds, kShowState);
+  session_service->SetWindowWorkspace(window_id(), kWorkspace);
+
+  session_service->MoveCurrentSessionToLastSession();
+
+  AddThreeNavigations();
+
+  service_->CreateHistoricalTab(live_tab(), -1);
+
+  RecreateService();
+
+  // We should get back two entries, one from the previous session and one from
+  // the tab restore service. The previous session entry should be first.
+  ASSERT_EQ(2U, service_->entries().size());
+
+  // The first entry should come from the session service.
+  sessions::TabRestoreService::Entry* entry = service_->entries().front().get();
+  ASSERT_EQ(sessions::TabRestoreService::WINDOW, entry->type);
+  sessions::TabRestoreService::Window* window =
+      static_cast<sessions::TabRestoreService::Window*>(entry);
+  ASSERT_EQ(kBounds, window->bounds);
+  ASSERT_EQ(kShowState, window->show_state);
+  ASSERT_EQ(kWorkspace, window->workspace);
+  ASSERT_EQ(1U, window->tabs.size());
+  EXPECT_EQ(0, window->selected_tab_index);
+  EXPECT_FALSE(window->tabs[0]->pinned);
+  ASSERT_EQ(1U, window->tabs[0]->navigations.size());
+  EXPECT_EQ(0, window->tabs[0]->current_navigation_index);
+  EXPECT_TRUE(url1_ == window->tabs[0]->navigations[0].virtual_url());
+
+  // Then the closed tab.
+  entry = (++service_->entries().begin())->get();
+  ASSERT_EQ(sessions::TabRestoreService::TAB, entry->type);
+  Tab* tab = static_cast<Tab*>(entry);
+  ASSERT_FALSE(tab->pinned);
+  ASSERT_EQ(3U, tab->navigations.size());
+  EXPECT_EQ(2, tab->current_navigation_index);
+  EXPECT_TRUE(url1_ == tab->navigations[0].virtual_url());
+  EXPECT_TRUE(url2_ == tab->navigations[1].virtual_url());
+  EXPECT_TRUE(url3_ == tab->navigations[2].virtual_url());
+}
+
 // Make sure pinned state is correctly loaded from session service.
 TEST_F(PersistentTabRestoreServiceTest, LoadPreviousSessionAndTabsPinned) {
   CreateSessionServiceWithOneWindow(true);
 
   SessionServiceFactory::GetForProfile(profile())->
       MoveCurrentSessionToLastSession();
 
   AddThreeNavigations();
 
   service_->CreateHistoricalTab(live_tab(), -1);
@@ skipping 283 matching lines @@
 
   EXPECT_FALSE(service_->IsLoaded());
   TestTabRestoreServiceObserver observer;
   service_->AddObserver(&observer);
   EXPECT_EQ(max_entries, service_->entries().size());
   SynchronousLoadTabsFromLastSession();
   EXPECT_TRUE(observer.got_loaded());
   EXPECT_TRUE(service_->IsLoaded());
   service_->RemoveObserver(&observer);
 }