Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp

Issue 2868923002: Blink rename follow-up: Use Chromium style in network_instrumentation namespace. (Closed)
Patch Set: Move network_instrumentation into blink namespace. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/network/NetworkInstrumentation.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
diff --git a/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp b/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
index 8b0af6a8cc8af140f162c1ee09f44be901ea29ef..310da83853f393841cd8fd0c472826588e206a88 100644
--- a/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
+++ b/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
@@ -428,7 +428,10 @@ bool IsBlacklistedInstanceMethodName(llvm::StringRef name) {
// https://crbug.com/672902: Should not rewrite names that mimick methods
// from std library.
- "at", "back", "empty", "erase", "front", "insert", "length", "size",
+ "at", "back",
+ "clear"
+ "empty",
+ "erase", "find", "front", "insert", "length", "size", "swap",
dcheng 2017/05/08 18:56:12 We can revert this file altogether for now as well
Łukasz Anforowicz 2017/05/08 19:06:03 Done. In theory we could have kept addition of "c
};
for (const auto& b : kBlacklistedNames) {
if (name == b)
« no previous file with comments | « third_party/WebKit/Source/platform/network/NetworkInstrumentation.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698