Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp

Issue 2868923002: Blink rename follow-up: Use Chromium style in network_instrumentation namespace. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
diff --git a/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp b/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
index 8b0af6a8cc8af140f162c1ee09f44be901ea29ef..304f6522ac5cf24fecaed79edb2dc6ff9060593a 100644
--- a/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
+++ b/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
@@ -428,7 +428,10 @@ bool IsBlacklistedInstanceMethodName(llvm::StringRef name) {
// https://crbug.com/672902: Should not rewrite names that mimick methods
// from std library.
- "at", "back", "empty", "erase", "front", "insert", "length", "size",
+ "at", "back",
+ "clear"
+ "empty",
+ "erase", "find", "front", "insert", "length", "size", "swap",
Łukasz Anforowicz 2017/05/08 17:09:45 Above formatting was produced by clang-format. I'
};
for (const auto& b : kBlacklistedNames) {
if (name == b)
@@ -1532,7 +1535,8 @@ int main(int argc, const char* argv[]) {
// Blink namespace matchers ========
auto blink_namespace_decl =
- namespaceDecl(anyOf(hasName("blink"), hasName("WTF")),
+ namespaceDecl(anyOf(hasName("blink"), hasName("WTF"),
+ hasName("network_instrumentation")),
hasParent(translationUnitDecl()));
auto protocol_namespace_decl =
namespaceDecl(hasName("protocol"),

Powered by Google App Engine
This is Rietveld 408576698