Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: third_party/WebKit/Source/platform/network/NetworkInstrumentation.h

Issue 2868923002: Blink rename follow-up: Use Chromium style in network_instrumentation namespace. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/network/NetworkInstrumentation.h
diff --git a/third_party/WebKit/Source/platform/network/NetworkInstrumentation.h b/third_party/WebKit/Source/platform/network/NetworkInstrumentation.h
index 39ccb39bf4be1fc25d3a44facf759f7bd7d8728f..794b5ec4cbef5748a75ad83891b647491820ad9a 100644
--- a/third_party/WebKit/Source/platform/network/NetworkInstrumentation.h
+++ b/third_party/WebKit/Source/platform/network/NetworkInstrumentation.h
@@ -14,28 +14,28 @@ class ResourceRequest;
namespace network_instrumentation {
Łukasz Anforowicz 2017/05/08 17:09:45 Maybe this shouldn't be a top-level namespace, but
dcheng 2017/05/08 18:23:44 Agreed. Is nesting it in blink non-trivial to do i
Łukasz Anforowicz 2017/05/08 18:48:35 Done.
-enum RequestOutcome { Success, Fail };
+enum RequestOutcome { kSuccess, kFail };
class PLATFORM_EXPORT ScopedResourceLoadTracker {
public:
- ScopedResourceLoadTracker(unsigned long resourceID,
+ ScopedResourceLoadTracker(unsigned long resource_id,
const blink::ResourceRequest&);
~ScopedResourceLoadTracker();
- void resourceLoadContinuesBeyondScope();
+ void ResourceLoadContinuesBeyondScope();
private:
// If this variable is false, close resource load slice at end of scope.
- bool m_resourceLoadContinuesBeyondScope;
+ bool resource_load_continues_beyond_scope_;
- const unsigned long m_resourceID;
+ const unsigned long resource_id_;
DISALLOW_COPY_AND_ASSIGN(ScopedResourceLoadTracker);
};
-void PLATFORM_EXPORT resourcePrioritySet(unsigned long resourceID,
+void PLATFORM_EXPORT ResourcePrioritySet(unsigned long resource_id,
blink::ResourceLoadPriority);
-void PLATFORM_EXPORT endResourceLoad(unsigned long resourceID, RequestOutcome);
+void PLATFORM_EXPORT EndResourceLoad(unsigned long resource_id, RequestOutcome);
} // namespace network_instrumentation

Powered by Google App Engine
This is Rietveld 408576698