Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1515)

Unified Diff: content/browser/renderer_host/media/media_devices_dispatcher_host_unittest.cc

Issue 2868853002: Add ability to retrieve capabilities for audio input devices to MediaDevicesDispatcherHost. (Closed)
Patch Set: fix Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/media_devices_dispatcher_host_unittest.cc
diff --git a/content/browser/renderer_host/media/media_devices_dispatcher_host_unittest.cc b/content/browser/renderer_host/media/media_devices_dispatcher_host_unittest.cc
index 488ea461cf37acfb30dfce353b074fa025d7a080..5185cbf23f45b9827b87f375ff947a7a685fd4c8 100644
--- a/content/browser/renderer_host/media/media_devices_dispatcher_host_unittest.cc
+++ b/content/browser/renderer_host/media/media_devices_dispatcher_host_unittest.cc
@@ -46,6 +46,7 @@ const int kProcessId = 5;
const int kRenderId = 6;
const size_t kNumFakeVideoDevices = 3;
const char kDefaultVideoDeviceID[] = "/dev/video2";
+const char kDefaultAudioDeviceID[] = "fake_audio_input_2";
void PhysicalDevicesEnumerated(base::Closure quit_closure,
MediaDeviceEnumeration* out,
@@ -79,8 +80,10 @@ class MediaDevicesDispatcherHostTest : public testing::Test {
// Make sure we use fake devices to avoid long delays.
base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
switches::kUseFakeDeviceForMediaStream,
- base::StringPrintf("device-count=%zu, video-input-default-id=%s",
- kNumFakeVideoDevices, kDefaultVideoDeviceID));
+ base::StringPrintf("device-count=%zu, video-input-default-id=%s, "
+ "audio-input-default-id=%s",
+ kNumFakeVideoDevices, kDefaultVideoDeviceID,
+ kDefaultAudioDeviceID));
audio_manager_.reset(
new media::MockAudioManager(base::ThreadTaskRunnerHandle::Get()));
audio_system_ = media::AudioSystemImpl::Create(audio_manager_.get());
@@ -114,6 +117,7 @@ class MediaDevicesDispatcherHostTest : public testing::Test {
MOCK_METHOD1(ValidOriginCallback,
void(const std::vector<std::vector<MediaDeviceInfo>>&));
MOCK_METHOD0(MockVideoInputCapabilitiesCallback, void());
+ MOCK_METHOD0(MockAudioInputCapabilitiesCallback, void());
void VideoInputCapabilitiesCallback(
std::vector<::mojom::VideoInputDeviceCapabilitiesPtr> capabilities) {
@@ -140,6 +144,20 @@ class MediaDevicesDispatcherHostTest : public testing::Test {
EXPECT_EQ(0U, capabilities.size());
}
+ void AudioInputCapabilitiesCallback(
+ std::vector<::mojom::AudioInputDeviceCapabilitiesPtr> capabilities) {
+ MockAudioInputCapabilitiesCallback();
+ // MediaDevicesManager always returns 3 fake audio input devices.
+ const size_t kNumExpectedEntries = 3;
+ EXPECT_EQ(kNumExpectedEntries, capabilities.size());
+ std::string expected_first_device_id =
+ GetHMACForMediaDeviceID(browser_context_.GetMediaDeviceIDSalt(),
+ origin_, kDefaultAudioDeviceID);
+ EXPECT_EQ(expected_first_device_id, capabilities[0]->device_id);
+ for (const auto& capability : capabilities)
+ EXPECT_TRUE(capability->parameters.IsValid());
+ }
+
protected:
void DevicesEnumerated(
const base::Closure& closure,
@@ -387,6 +405,18 @@ TEST_F(MediaDevicesDispatcherHostTest, GetVideoInputCapabilities) {
run_loop.Run();
}
+TEST_F(MediaDevicesDispatcherHostTest, GetAudioInputCapabilities) {
+ base::RunLoop run_loop;
+ EXPECT_CALL(*this, MockAudioInputCapabilitiesCallback())
+ .WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); }));
+ host_->GetAudioInputCapabilities(
+ origin_,
+ base::Bind(
+ &MediaDevicesDispatcherHostTest::AudioInputCapabilitiesCallback,
+ base::Unretained(this)));
+ run_loop.Run();
+}
+
TEST_F(MediaDevicesDispatcherHostTest, GetVideoInputCapabilitiesUniqueOrigin) {
base::RunLoop run_loop;
EXPECT_CALL(*this, MockVideoInputCapabilitiesCallback())

Powered by Google App Engine
This is Rietveld 408576698