Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 286883002: [Media] Add a Finch experiment to enable the permission bubble request. (Closed)

Created:
6 years, 7 months ago by Greg Billock
Modified:
6 years, 7 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Visibility:
Public.

Description

[Media] Add a Finch experiment to enable the permission bubble request. R=xhwang@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273099

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/browser/media/media_capture_devices_dispatcher.cc View 1 2 3 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Greg Billock
6 years, 7 months ago (2014-05-14 18:33:28 UTC) #1
xhwang
I am not familiar with this code. +sergeyu who's a better owner of this file.
6 years, 7 months ago (2014-05-14 19:43:16 UTC) #2
Greg Billock
On 2014/05/14 19:43:16, xhwang wrote: > I am not familiar with this code. +sergeyu who's ...
6 years, 7 months ago (2014-05-19 15:12:51 UTC) #3
Sergey Ulanov
lgtm https://codereview.chromium.org/286883002/diff/20001/chrome/browser/media/media_capture_devices_dispatcher.cc File chrome/browser/media/media_capture_devices_dispatcher.cc (right): https://codereview.chromium.org/286883002/diff/20001/chrome/browser/media/media_capture_devices_dispatcher.cc#newcode69 chrome/browser/media/media_capture_devices_dispatcher.cc:69: bool WebRTCPermissionBubbleExperimentEnabled() { s/WebRTC/MediaSstream/. WebRTC is too generic ...
6 years, 7 months ago (2014-05-19 18:39:16 UTC) #4
Greg Billock
https://codereview.chromium.org/286883002/diff/20001/chrome/browser/media/media_capture_devices_dispatcher.cc File chrome/browser/media/media_capture_devices_dispatcher.cc (right): https://codereview.chromium.org/286883002/diff/20001/chrome/browser/media/media_capture_devices_dispatcher.cc#newcode69 chrome/browser/media/media_capture_devices_dispatcher.cc:69: bool WebRTCPermissionBubbleExperimentEnabled() { On 2014/05/19 18:39:17, Sergey Ulanov wrote: ...
6 years, 7 months ago (2014-05-27 18:08:39 UTC) #5
Greg Billock
The CQ bit was checked by gbillock@chromium.org
6 years, 7 months ago (2014-05-27 18:08:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/286883002/40001
6 years, 7 months ago (2014-05-27 18:10:47 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 7 months ago (2014-05-27 21:54:55 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-28 01:21:23 UTC) #9
Message was sent while issue was closed.
Change committed as 273099

Powered by Google App Engine
This is Rietveld 408576698