getElementsByTagName() should take a qualifiedName in parameter

third_party/WebKit/Source/core/dom/TagCollection.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 15 matching lines @@
 
 #include "core/html/HTMLCollection.h"
 #include "platform/wtf/text/AtomicString.h"
 
 namespace blink {
 
 // Collection that limits to a particular tag.
 class TagCollection : public HTMLCollection {
  public:
   static TagCollection* Create(ContainerNode& root_node,
-                               const AtomicString& namespace_uri,
-                               const AtomicString& local_name) {
-    DCHECK(namespace_uri != g_star_atom);
-    return new TagCollection(root_node, kTagCollectionType, namespace_uri,
-                             local_name);
-  }
-
-  static TagCollection* Create(ContainerNode& root_node,
                                CollectionType type,
-                               const AtomicString& local_name) {
+                               const AtomicString& qualified_name) {
     DCHECK_EQ(type, kTagCollectionType);
-    return new TagCollection(root_node, kTagCollectionType, g_star_atom,
-                             local_name);
+    return new TagCollection(root_node, kTagCollectionType, qualified_name);
   }
 
   ~TagCollection() override;
 
   bool ElementMatches(const Element&) const;
 
  protected:
   TagCollection(ContainerNode& root_node,
                 CollectionType,
-                const AtomicString& namespace_uri,
-                const AtomicString& local_name);
+                const AtomicString& qualified_name);
+
+  AtomicString qualified_name_;
+};
+
+class TagCollectionNS : public HTMLCollection {
+ public:
+  static TagCollectionNS* Create(ContainerNode& root_node,
+                                 const AtomicString& namespace_uri,
+                                 const AtomicString& local_name) {
+    return new TagCollectionNS(root_node, kTagCollectionNSType, namespace_uri,
+                               local_name);
+  }
+
+  static TagCollectionNS* Create(ContainerNode& root_node,

[fs, 2017/05/08 14:20:36]

Is this even called?

[Shanmuga Pandi, 2017/05/10 12:17:22]

Removed

+                                 CollectionType type,
+                                 const AtomicString& local_name) {
+    DCHECK_EQ(type, kTagCollectionNSType);
+    return new TagCollectionNS(root_node, kTagCollectionNSType, g_star_atom,
+                               local_name);
+  }
+
+  ~TagCollectionNS() override;
+
+  bool ElementMatches(const Element&) const;
+
+ protected:

[tkent, 2017/05/09 00:28:01]

should be private?

[Shanmuga Pandi, 2017/05/10 12:17:22]

Done.

+  TagCollectionNS(ContainerNode& root_node,
+                  CollectionType,
+                  const AtomicString& namespace_uri,
+                  const AtomicString& local_name);
 
   AtomicString namespace_uri_;
   AtomicString local_name_;
 };
 
 DEFINE_TYPE_CASTS(TagCollection,
                   LiveNodeListBase,
                   collection,
                   collection->GetType() == kTagCollectionType,
                   collection.GetType() == kTagCollectionType);
 
+DEFINE_TYPE_CASTS(TagCollectionNS,
+                  LiveNodeListBase,
+                  collection,
+                  collection->GetType() == kTagCollectionNSType,
+                  collection.GetType() == kTagCollectionNSType);
+
 }  // namespace blink
 
 #endif  // TagCollection_h