Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3666)

Unified Diff: chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc

Issue 2868783002: Move requests from Show() argument to PermissionPrompt::Delegate (Closed)
Patch Set: tweak comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/permission_bubble/permission_prompt_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
diff --git a/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc b/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
index f5f1cb28a391ad9b4c61e194c444d33996df4983..d01ab4c6b917085077cd05456420a43a90c9eff8 100644
--- a/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
+++ b/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
@@ -402,16 +402,15 @@ void PermissionPromptImpl::SetDelegate(Delegate* delegate) {
delegate_ = delegate;
}
-void PermissionPromptImpl::Show(const std::vector<PermissionRequest*>& requests,
- const std::vector<bool>& values) {
+void PermissionPromptImpl::Show() {
DCHECK(browser_);
DCHECK(browser_->window());
if (bubble_delegate_)
bubble_delegate_->CloseBubble();
- bubble_delegate_ =
- new PermissionsBubbleDialogDelegateView(this, requests, values);
+ bubble_delegate_ = new PermissionsBubbleDialogDelegateView(
+ this, delegate_->Requests(), delegate_->AcceptStates());
// Set |parent_window| because some valid anchors can become hidden.
bubble_delegate_->set_parent_window(
« no previous file with comments | « chrome/browser/ui/views/permission_bubble/permission_prompt_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698