Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc

Issue 2868783002: Move requests from Show() argument to PermissionPrompt::Delegate (Closed)
Patch Set: rm vector on android Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
diff --git a/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc b/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
index f5f1cb28a391ad9b4c61e194c444d33996df4983..96e6b0c72dcc20a06e2c800a34702caf8b439618 100644
--- a/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
+++ b/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
@@ -402,16 +402,12 @@ void PermissionPromptImpl::SetDelegate(Delegate* delegate) {
delegate_ = delegate;
}
-void PermissionPromptImpl::Show(const std::vector<PermissionRequest*>& requests,
- const std::vector<bool>& values) {
+void PermissionPromptImpl::Show() {
DCHECK(browser_);
DCHECK(browser_->window());
- if (bubble_delegate_)
- bubble_delegate_->CloseBubble();
raymes 2017/05/11 01:17:55 Should this be removed?
Timothy Loh 2017/05/11 04:42:08 It's dead code (Show is only called when there's n
-
- bubble_delegate_ =
- new PermissionsBubbleDialogDelegateView(this, requests, values);
+ bubble_delegate_ = new PermissionsBubbleDialogDelegateView(
+ this, delegate_->Requests(), delegate_->AcceptStates());
// Set |parent_window| because some valid anchors can become hidden.
bubble_delegate_->set_parent_window(

Powered by Google App Engine
This is Rietveld 408576698