Move requests from Show() argument to PermissionPrompt::Delegate

chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.h

Index: chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.h
diff --git a/chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.h b/chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.h
index 66a8295c998769e718f1d96e113b64dffc22fc0b..4ca954f684d573da7c77c0568934e3f9b122b845 100644
--- a/chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.h
+++ b/chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.h
@@ -21,6 +21,10 @@ class Browser;
 class TestPermissionBubbleViewDelegate : public PermissionPrompt::Delegate {
  public:
   TestPermissionBubbleViewDelegate();
+  ~TestPermissionBubbleViewDelegate() override;
+
+  const std::vector<PermissionRequest*>& Requests() override;
+  const std::vector<bool>& AcceptStates() override;
 
   void ToggleAccept(int, bool) override {}
   void TogglePersist(bool) override {}
@@ -28,7 +32,14 @@ class TestPermissionBubbleViewDelegate : public PermissionPrompt::Delegate {
   void Deny() override {}
   void Closing() override {}
 
+  void SetRequests(std::vector<PermissionRequest*> requests) {

[raymes, 2017/05/11 01:17:54]

nit: set_requests

[Timothy Loh, 2017/05/11 04:42:08]

Done.

+    requests_ = requests;
+  }
+
  private:
+  std::vector<PermissionRequest*> requests_;
+  std::vector<bool> accept_states_;
+
   DISALLOW_COPY_AND_ASSIGN(TestPermissionBubbleViewDelegate);
 };
 
@@ -45,11 +56,11 @@ class PermissionBubbleBrowserTest : public ExtensionBrowserTest {
   // Opens an app window, and returns the associated browser.
   Browser* OpenExtensionAppWindow();
 
-  std::vector<PermissionRequest*> requests();
-  std::vector<bool> accept_states() { return accept_states_; }
   PermissionPrompt::Delegate* test_delegate() { return &test_delegate_; }
 
  private:
+  std::vector<PermissionRequest*> requests();

[raymes, 2017/05/11 01:17:54]

nit: no ()

[Timothy Loh, 2017/05/11 04:42:08]

It's a function... anyway I reworked it a bit (inlined the function).

+
   TestPermissionBubbleViewDelegate test_delegate_;
   std::vector<std::unique_ptr<PermissionRequest>> requests_;
   std::vector<bool> accept_states_;