Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: chrome/browser/ui/permission_bubble/mock_permission_prompt.cc

Issue 2868783002: Move requests from Show() argument to PermissionPrompt::Delegate (Closed)
Patch Set: tweak comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/permission_bubble/mock_permission_prompt.h" 5 #include "chrome/browser/ui/permission_bubble/mock_permission_prompt.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/run_loop.h" 8 #include "base/run_loop.h"
9 #include "chrome/browser/permissions/permission_request_manager.h" 9 #include "chrome/browser/permissions/permission_request_manager.h"
10 #include "chrome/browser/ui/permission_bubble/mock_permission_prompt_factory.h" 10 #include "chrome/browser/ui/permission_bubble/mock_permission_prompt_factory.h"
11 11
12 MockPermissionPrompt::~MockPermissionPrompt() { 12 MockPermissionPrompt::~MockPermissionPrompt() {
13 Hide(); 13 Hide();
14 } 14 }
15 15
16 void MockPermissionPrompt::Show(const std::vector<PermissionRequest*>& requests, 16 void MockPermissionPrompt::Show() {
17 const std::vector<bool>& accept_state) {
18 factory_->ShowView(this); 17 factory_->ShowView(this);
19 factory_->show_count_++; 18 factory_->show_count_++;
20 factory_->requests_count_ = manager_->requests_.size(); 19 factory_->requests_count_ = manager_->requests_.size();
21 for (const PermissionRequest* request : manager_->requests_) { 20 for (const PermissionRequest* request : manager_->requests_) {
22 factory_->request_types_seen_.push_back( 21 factory_->request_types_seen_.push_back(
23 request->GetPermissionRequestType()); 22 request->GetPermissionRequestType());
24 } 23 }
25 factory_->UpdateResponseType(); 24 factory_->UpdateResponseType();
26 is_visible_ = true; 25 is_visible_ = true;
27 } 26 }
(...skipping 23 matching lines...) Expand all
51 bool MockPermissionPrompt::IsVisible() { 50 bool MockPermissionPrompt::IsVisible() {
52 return is_visible_; 51 return is_visible_;
53 } 52 }
54 53
55 MockPermissionPrompt::MockPermissionPrompt(MockPermissionPromptFactory* factory, 54 MockPermissionPrompt::MockPermissionPrompt(MockPermissionPromptFactory* factory,
56 PermissionRequestManager* manager) 55 PermissionRequestManager* manager)
57 : factory_(factory), 56 : factory_(factory),
58 manager_(manager), 57 manager_(manager),
59 can_update_ui_(true), 58 can_update_ui_(true),
60 is_visible_(false) {} 59 is_visible_(false) {}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698