Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1402)

Unified Diff: net/quic/chromium/quic_chromium_client_session.cc

Issue 2868633002: Create a QuicChromiumClientStream::Handle class for allowing a stream (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/chromium/quic_chromium_client_session.h ('k') | net/quic/chromium/quic_chromium_client_stream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/quic_chromium_client_session.cc
diff --git a/net/quic/chromium/quic_chromium_client_session.cc b/net/quic/chromium/quic_chromium_client_session.cc
index 6d46a328b9b570d5c18509b00c948e12264835ec..4c70e143387ff4fe0681128b4877d521f9fea755 100644
--- a/net/quic/chromium/quic_chromium_client_session.cc
+++ b/net/quic/chromium/quic_chromium_client_session.cc
@@ -301,13 +301,14 @@ int QuicChromiumClientSession::Handle::RequestStream(
return stream_request_->StartRequest(callback);
}
-QuicChromiumClientStream* QuicChromiumClientSession::Handle::ReleaseStream(
+std::unique_ptr<QuicChromiumClientStream::Handle>
+QuicChromiumClientSession::Handle::ReleaseStream(
QuicChromiumClientStream::Delegate* delegate) {
DCHECK(stream_request_);
- auto* stream = stream_request_->ReleaseStream(delegate);
+ auto handle = stream_request_->ReleaseStream(delegate);
stream_request_.reset();
- return stream;
+ return handle;
}
int QuicChromiumClientSession::Handle::WaitForHandshakeConfirmation(
@@ -376,14 +377,13 @@ int QuicChromiumClientSession::StreamRequest::StartRequest(
return rv;
}
-QuicChromiumClientStream*
+std::unique_ptr<QuicChromiumClientStream::Handle>
QuicChromiumClientSession::StreamRequest::ReleaseStream(
QuicChromiumClientStream::Delegate* delegate) {
DCHECK(stream_);
QuicChromiumClientStream* stream = stream_;
stream_ = nullptr;
- stream->SetDelegate(delegate);
- return stream;
+ return stream->CreateHandle(delegate);
}
void QuicChromiumClientSession::StreamRequest::OnRequestCompleteSuccess(
« no previous file with comments | « net/quic/chromium/quic_chromium_client_session.h ('k') | net/quic/chromium/quic_chromium_client_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698